Comments (5)
Got you, thanks
from sidekiq-status.
+1
from sidekiq-status.
Lost a while hunting this bug, +1 on a fix.
from sidekiq-status.
Temporary workaround
Sidekiq::Status.unschedule(job_id) if job_id
Literally came here to see if anyone had already submitted this bug. Nice one
from sidekiq-status.
@utgarda - Fixed this issue in PR #69.
Problem was with following line
scheduled_jobs.each { |job_listing| (return job_listing) if job_listing.include?("\"jid\":\"#{job_id}") }
Above line was checking patterns inclusion only, so following was getting true if unschedule(nil)
Ex: job_listing
"{\"retry\":false,\"queue\":\"default\",\"backtrace\":true,\"expires_in\":86400,\"class\":\"MyWorker\",\"args\":[10],\"jid\":\"a28ba4cc9b0396da3fb2c410\",\"enqueued_at\":1449306022.4224896}"
job_listing.include?("\"jid\":\"#{nil}")
=> \"jid\":\"
# resulting in true as \"jid\":\"a28ba4cc9b0396da3fb2c410\" has inclusion of \"jid\":\"
Replaced inclusion check with this, Additional I have tested this change and it will handle all cases like unschedule(nil)
, unschedule('')
and unschedule(other_jid)
.
from sidekiq-status.
Related Issues (20)
- undefined method `get_all' for Sidekiq::Status:Module when accessing `localhost:8000/statuses` HOT 3
- Remove button leads to a 404 Not Found HOT 3
- `#store` doesn't work in tests HOT 2
- Finishing a worker at < total results status = completed and < 100% progress HOT 1
- Redis::CannotConnectError also after enabling testing mode HOT 1
- Sidekiq::Status doesn't play well with Sidekiq Enterprise's encryption feature HOT 1
- Pagination
- Add option to skip storing job args in status key HOT 1
- Flaky way to check for job Klass in client_middleware.rb HOT 1
- Filtering by worker
- Call Sidekiq::Status.cancel with Ruby 3.0.0 HOT 1
- `store` function and wrong expiration
- [Request] Add a method append
- Sidekiq halt helper changed HOT 1
- Problem with sidekia-status middleware after upgrading to rails 6
- Sidekiq::Job renamed to Sidekiq::JobRecord HOT 1
- Get all complete jobs
- Empty worker jid in status page. Cant access specific job status page
- Perfomance of the sidekiq status ui page
- Transition from `Worker` to `Job`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sidekiq-status.