Giter Club home page Giter Club logo

Comments (5)

utgarda avatar utgarda commented on July 20, 2024

Got you, thanks

from sidekiq-status.

achernik avatar achernik commented on July 20, 2024

+1

from sidekiq-status.

jmnsf avatar jmnsf commented on July 20, 2024

Lost a while hunting this bug, +1 on a fix.

from sidekiq-status.

andyryan avatar andyryan commented on July 20, 2024

Temporary workaround

Sidekiq::Status.unschedule(job_id) if job_id

Literally came here to see if anyone had already submitted this bug. Nice one

from sidekiq-status.

pramodshinde avatar pramodshinde commented on July 20, 2024

@utgarda - Fixed this issue in PR #69.
Problem was with following line

scheduled_jobs.each { |job_listing| (return job_listing) if job_listing.include?("\"jid\":\"#{job_id}") }

Above line was checking patterns inclusion only, so following was getting true if unschedule(nil)
Ex: job_listing

"{\"retry\":false,\"queue\":\"default\",\"backtrace\":true,\"expires_in\":86400,\"class\":\"MyWorker\",\"args\":[10],\"jid\":\"a28ba4cc9b0396da3fb2c410\",\"enqueued_at\":1449306022.4224896}" 
job_listing.include?("\"jid\":\"#{nil}")
=> \"jid\":\" 
# resulting in true as \"jid\":\"a28ba4cc9b0396da3fb2c410\" has inclusion of \"jid\":\"

Replaced inclusion check with this, Additional I have tested this change and it will handle all cases like unschedule(nil), unschedule('') and unschedule(other_jid).

from sidekiq-status.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.