Comments (5)
kbonney
commented on September 26, 2024
This error occurs because we are using deprecated API for pandas Series objects as described on this pandas documentation page.
The simple fix is to use the correct method items for a series rather than iteritems. @MunsakaPKM, if you are interested in contributing to WNTR please feel welcome to create a PR to address this.
from wntr.
MunsakaPKM
commented on September 26, 2024
Dear Kirk,
Thank you so much for your prompt response and for considering me to
contribute to WNTR! As a student, I'm thrilled to have the opportunity to
contribute to a project of this importance. I'm eager to learn and gain
more experience. However, I must admit that I'm new to open-source
development and could benefit from guidance on how to get started. Would it
be possible for you to provide some advice on creating a PR ? Any tips or
resources you can share would be appreciated.
Thanks again for your help and support.
Best regards,
Prince Munsaka
…On Mon, Apr 22, 2024 at 4:13 PM Kirk Bonney ***@***.***> wrote:
This is caused because we are using deprecated API for pandas Series
objects as described on this pandas documentation page
<https://pandas.pydata.org/pandas-docs/version/1.5/reference/api/pandas.Series.iteritems.html>
.
The simple fix is to use the correct method items for a series rather
than iteritems. @MunsakaPKM <https://github.com/MunsakaPKM>, if you are
interested in contributing to WNTR please feel welcome to create a PR to
address this.
—
Reply to this email directly, view it on GitHub
<#416 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEHWEYXH7F3LTVNNZUMLDXDY6ULJVAVCNFSM6AAAAABGQO23AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRZGYYDEMJWGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from wntr.
kbonney
commented on September 26, 2024
Sure, here are some steps to help get you started:
- Create a fork of WNTR and clone it locally.
- Install WNTR following the developer instructions , except instead of using USEPA's WNTR, use the WNTR from your fork. I recommend installing to a fresh python environment.
- Make the changes we discussed to the code on a new branch. You can test these changes by running
pytest wntr, but they will also be automatically tested when you create the pull request. - Commit these changes and push the branch to your fork.
- Make a PR for your new branch. Fill out the template that we provide.
Once you done that we can look at the next steps.
from wntr.
kbonney
commented on September 26, 2024
Since this bug is not showing up in our current test suite, there should also be an update to the tests to make sure this code is covered properly. I wouldn't worry about this in your PR @MunsakaPKM, I can take care of it on the side.
from wntr.
MunsakaPKM
commented on September 26, 2024
Thank you, I appreciate it. I will review the instructions and begin
working on the steps at my earliest convenience. Once I have made progress,
I will keep you informed and proceed accordingly.
…On Wed, Apr 24, 2024 at 6:01 PM Kirk Bonney ***@***.***> wrote:
Since this bug is not showing up in our current test suite, there should
also be an update to the tests to make sure this code is covered properly.
I wouldn't worry about this in your PR @MunsakaPKM
<https://github.com/MunsakaPKM>, I can take care of it on the side.
—
Reply to this email directly, view it on GitHub
<#416 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEHWEYVFBS7TYJ4LEKHZTTLY67JM3AVCNFSM6AAAAABGQO23AKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGI4TMOJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
from wntr.
Related Issues (20)
- Create a control object or rule object from text input HOT 5
- Get the reactions tab in the inp file from a water network instance HOT 1
- Add PBV support to [VALVES] section
- Generating Interactive leaflet networks HOT 7
- Pipe status problem HOT 4
- AttributeError: 'WaterNetworkModel' object has no attribute 'write_inpfile' HOT 3
- Differences with my epanet from zero model and inp from wntr model HOT 4
- Values in [DEMANDS] section are repetead and others are missing HOT 8
- Unable to remove leaks from network model HOT 3
- Not able to save the network with modified elements as an INP file. HOT 2
- EPANET Error 110 HOT 1
- Todini Index Calculation for the Net6 network - Values outside the range [0,1] HOT 5
- Update EPANET binaries for MacOS arm64 HOT 1
- Version compatibility for dependencies HOT 1
- Pressure Threshold for Resilience indices like Todini and MRI HOT 2
- Problems to run parallel processing with WNTR / EPANET HOT 2
- WARNING - Writing a minimal INP file without saved non-WNTR options (energy, etc.) -- obselete?
- GIS files written with wrong column title for 'name' HOT 1
- Allow import of 'base_demand' and 'demand_pattern' from GIS files HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wntr.