Adding duration filtering about angular-moment HOT 8 CLOSED

Ok looks like it works :

{{data.duration | amDurationFormat:'milliseconds':true}}

And I just add :

.filter('amDurationFormat', ['$window', function ($window) {
        'use strict';

        return function (value, format, suffix) {
            if (typeof value === 'undefined' || value === null) {
                return '';
            }

            if (!isNaN(parseFloat(value)) && isFinite(value)) {
                return '';
            }

            // else assume the given value is a duration in milliseconds
            return $window.moment.duration(value, format).humanize(suffix);
        };
    }])

I'll try to add the text and then pull request.

from angular-moment.

Thanks Gabriel!

Please also add tests for the new directive (in the file test.js). You can easily run tests (and also code style checks) by running grunt test from command line. In order to setup this, you need 2 simple steps:

1. If you don't have grunt install, run npm install -g grunt-cli
2. Run npm install in the angular-moment source directory

This will allow you to run the tests & jshint by simply typing grunt test. The tests are pretty simple and quick to create, just look how they are done for the amDateFormat directive. If you need any assistance with this, please let me know.

Thank you so much!

from angular-moment.

Hi Gabriel, how is it going with adding the new filter? If you need any assistance feel free to ping me here

from angular-moment.

Sorry,

Did not get time to do so :)
Going to do it this weekend.

Thanks,

from angular-moment.

Excellent, thank you very much Gabriel!

from angular-moment.

done :)

forking and pulling soon. 

from angular-moment.

Awesome!

from angular-moment.

Thanks, released as 0.5.1

from angular-moment.