Modularize scalars about graphql-scalars HOT 9 CLOSED

You don't need to separate into multiple packages, it's unnecessary complexity for the maintainer, just separating into subfolders solves the problem:

import { typeDef, resolver } from 'graphql-scalars/URL'
import { typeDef, resolver } from 'graphql-scalars/PhoneNumber'

from graphql-scalars.

Why is the package bundled? Don't bundle it and allow consumers to deep import the parts they need. That way we're not needlessly loading 3000+ lines of source code into memory just for the sake of a single scalar.

from graphql-scalars.

All scalars are treeshakable. You can use a bundler like webpack if the bundle size is important for you.
We're still open for PRs for more :)
I think it is already small;
https://bundlephobia.com/package/[email protected]

from graphql-scalars.

Of course, but the other benefit is that consumers won't be required to bundle and tree-shake.

from graphql-scalars.

We already have this. You need to import ‘SomeDefinition’ and ‘SomeResolver’ for example.

from graphql-scalars.

I was meaning separate NPM packages. For example, there is lodash and lodash.merge. I am aware I don't need to import everything from the graphql-scalars module.

I thought it could be a nice to have feature request, obviously not critical. This "issue" can stay closed regardless. Seemingly this package will grow to encase a variety of scalars, and this would enable being more selective about what dependencies are actually necessary to support each scalar.

from graphql-scalars.

@ravangen We can keep it open :) Sorry for misunderstanding. That would be a nice feature

from graphql-scalars.

@ravangen @httpiago This package is already tree-shakable so do you have a specific case needs that kind of feature?

from graphql-scalars.

We can close this, I don't think it is worth any extra process overhead on the maintainers.

I had been using lodash the other day and had simply thought that their option to use separate micro packages was a nice feature. 90% of these scalars don't apply to my current uses cases.

from graphql-scalars.