Comments (17)
Any update on merging the swift3
branch into master
and issuing a release? Especially for Cocoapods?
from armchair.
Meanwhile for swift 3 projects, put this in your Podfile:
pod 'Armchair', :git => 'https://github.com/UrbanApps/Armchair.git', :branch => 'swift3'
Works fine with Swift 3.0.1
from armchair.
@donpironet There is a swift3 branch you can use here
from armchair.
Why not have a separate Swift 3 branch until it's out of beta like a lot of other libraries do?
from armchair.
Can't accept PR's until out of beta
from armchair.
Whats the status?
from armchair.
I made the swift3 branch shortly after the above comment, nobody has send me a pull request to it as requested. https://github.com/UrbanApps/Armchair/tree/swift3
from armchair.
Status? Need this to work on xcode 8 with carthage.
from armchair.
@bjaskj you can see the swift 3 branch here: https://github.com/UrbanApps/Armchair/tree/swift3 feel free to submit a pull request if it is not working for you.
from armchair.
Can you please update the project to Swift 3 so I can update via carthage?
from armchair.
Thanks. What do I need to specify to get it via carthage?
EDIT: it can be done via git "https://github.com/UrbanApps/Armchair.git" "swift3"
from armchair.
+1 for cocoapods request.
from armchair.
+1
from armchair.
+1
from armchair.
Is there any good alternative? Swift 3.0.1 released and there's still nothing happened
from armchair.
I haven't had time to resolve the merge conflicts in the other PR's that update to the swift 3 branch. If somebody wants to submit a PR with the appropriate edits to the master branch, I will take a look and merge if all is good.
from armchair.
I just wanted to use this library but it seems it's not being maintained any more. @coneybeare clearly lost interest (it's more than half a year after the Swift 3 release and still no native Swift 3 support!) so I'm unstar-ing this and opting for Appirater instead which is written in Objective-C (which I wanted to prevent) but at least it's actively maintained and maps well to Swift.
In the future there will probably be a completely different approach to this issue anyway as Apple has introduced the new in-app review APIs. See the Human Interface Guidelines for it here. We just need to wait until iOS 10.3 is far more distributed amongst users ...
from armchair.
Related Issues (20)
- rateApp() not working, "Write Review" page in AppStore cannot be opened. HOT 3
- Cant figure it out HOT 1
- Multiple Prompts at once HOT 1
- Armchair & UIAlertView HOT 1
- Can't get this working in Debug mode HOT 1
- Mac Version doesn't compile HOT 2
- AlertController not showing up with warning: Attempt to present UIAlertController on UINavigationController whose view is not in the window hierarchy! HOT 1
- Release? HOT 1
- SKStoreReviewController keeps showing even though daysBeforeReminding is set to 3 and significantEventsUntilPrompt is set to 40. HOT 1
- Cannot build with Carthage HOT 2
- Prompt is showing , but after pressing Rate now button not showing , juts infinite loading HOT 1
- Import Error and Shared Instance Error
- Swift 4.0 support
- Incorrect calculation in "RemindMeLater" code
- don't show armchair pop up ever in one particular view controller. HOT 1
- I want to hide cancel/No thanks button and give user 2 options (Rate Now, Remind me later) only.
- package.swift is missing HOT 1
- Major bug with app review! HOT 1
- "Rate app-name" link goes to the app's App Store page, not the "write review" page
- All Armchair .lproj files are included with cocoapods "use_frameworks! :linkage => :static"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from armchair.