Giter Club home page Giter Club logo

Comments (11)

coneybeare avatar coneybeare commented on August 17, 2024

I will entertain a pull request that maintains backwards compatibility.

from armchair.

phimage avatar phimage commented on August 17, 2024

@jlaws just set usesAlertController to true for the moment

@coneybeare Maybe we could change the default value of usesAlertController to true? or (according to iOS version > 9)

from armchair.

coneybeare avatar coneybeare commented on August 17, 2024

I like that idea of setting the default to true based on operatingSystemVersion

from armchair.

jlaws avatar jlaws commented on August 17, 2024

Finally got around to looking at this thread again. My concern was the build warning:

Armchair-Swift.h:130:20: 'UIAlertView' is deprecated: first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead

Considering that 95% or 97.5% of devices are running iOS 8+ it is probably safe to make the min target for the library iOS 8 and use alert controllers exclusively. Just create a fork and leave the old cocoapods for people who want to target earlier versions.

Another option is to suppress the warning inside the library.

from armchair.

tbaranes avatar tbaranes commented on August 17, 2024

I agree with @jlaws solution. If you really don't want to target only iOS8+, you should suppress that warning directly in the library.

from armchair.

coneybeare avatar coneybeare commented on August 17, 2024

I'd consider a pull request of that warning suppression

from armchair.

virl avatar virl commented on August 17, 2024

Please fix that warning. Also iOS8+ only is fine.

from armchair.

KMessina1 avatar KMessina1 commented on August 17, 2024

This really needs to be fixed, every time I do a clean build it gives me the warning. At this point, its pretty annoying. I moved to this library so that it would be modern and a Swift solution to Appirater.

from armchair.

coneybeare avatar coneybeare commented on August 17, 2024

@KMessina1 I will entertain any pull request surpassing the warning, please feel free to contribute.

from armchair.

vazra avatar vazra commented on August 17, 2024

@coneybeare @jlaws any update on this? It's still the same.

from armchair.

coneybeare avatar coneybeare commented on August 17, 2024

UIAlertView has already been completely removed from source in master.

from armchair.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.