Python 3.12: ModuleNotFoundError: No module named 'setuptools' about dill HOT 5 CLOSED

Ah sorry, I failed to update my branch properly from upstream and it was very out of date. All is good when updating it.

At least it helped update the docs :) Sorry again for the noise, and thank you for testing 3.12 pre-releases!

from dill.

@EliahKagan: Thanks for your posting. I was wondering the same thing. Good catch on the outdated docs.

from dill.

I am unable to reproduce this at the tip of the master branch (currently b66411e). Does this happen at the tip of master, or with any recent releases? This part of your output suggests you may be testing a very old version:

py312: install_package> python -I -m pip install --force-reinstall --no-deps /private/tmp/dill/.tox/.tmp/package/1/dill-0.3.2.dev0.tar.gz

dill 0.3.2 was released in June 2020, with 0.3.3 in November 2020. So I don't think tox runs on any recent dill should show that. The corresponding part of my tox -e py312 output shows:

py312: install_package> python -I -m pip install --force-reinstall --no-deps /home/ek/repos-wsl/dill/.tox/.tmp/package/2/dill-0.3.8.dev0.tar.gz

And for my next line, instead of:

py312: commands[0]> .tox/py312/bin/python setup.py build

I have:

py312: commands[0]> .tox/py312/bin/python -m pip install .

This is what I expect, because tox.ini does not directly use setup.py since #469 (per this diff).

With that said, even if I am understanding correctly and the problem you've reported here was effectively fixed in #469, it seems to me that there is at least one thing that should be updated, relating to Python 3.12 not having setuptools installed by default:

However, that cannot be the cause of test failures, because it appears in a docstring (that is not a doctest).

from dill.

No problem--and thanks for the fix for that (#621)!

I've noticed that the new instructions give an installation command that assumes the current directory is the location of that file (they refer to the repository root as ../..). This differs from the old instructions, which assumed they were run in the root of the repository (where seup.py is).

Although I find this odd, I'm reluctant to propose that it be changed, in case it is intentional.

from dill.

I've noticed that the new instructions give an installation command that assumes the current directory is the location of that file (they refer to the repository root as ../..). This differs from the old instructions, which assumed they were run in the root of the repository (where seup.py is).

Although I find this odd, I'm reluctant to propose that it be changed, in case it is intentional.

Yeah, it's intentional. I thought it a bit odd too, but I think it more correct. Maybe it'd be better to say one should "cd to the package root" then python -m pip install . -- that might be better...

from dill.