Giter Club home page Giter Club logo

Comments (4)

jameslamb avatar jameslamb commented on May 21, 2024

happy to report we have near-100% coverage now as of #66! Still leaving this open...we would love help covering the last few tough-to-hit cases

from uptasticsearch.

jameslamb avatar jameslamb commented on May 21, 2024

coverage as of #72

image

^ note that those get_fields lines are actually covered...there are two scrolling strategies (one for new, one for legacy), and only one of the two gets covered in any single set of tests (on a single ES version). They're both covered because our CI stuff tests over many versions

from uptasticsearch.

jameslamb avatar jameslamb commented on May 21, 2024

so our coverage is above 97%! Those last few lines would be real real hard to cover, but someone is welcome to take this up if they really want

from uptasticsearch.

jameslamb avatar jameslamb commented on May 21, 2024

If you want to contribute on this, here's how you can check the test coverage:

  1. Spin up Elasticsearch locally and seed it with data. This requires that you have docker running
./setup_local.sh 6.2
  1. Install the package and run the R tests
make install_r
make coverage_r

You should see something like this in the terminal

image

and a file coverage.html should open in your default web browser. That file shows detailed information on which files have untested code and which lines specifically are untested.

  1. Add tests in R-package/tests/testthat and repeat step 2

  2. When you're done, be sure to clean up your local environment

./cleanup_local.sh

PRs that add any test coverage are welcomed! You do not have to get to 100% in one shot.

from uptasticsearch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.