Comments (4)
happy to report we have near-100% coverage now as of #66! Still leaving this open...we would love help covering the last few tough-to-hit cases
from uptasticsearch.
coverage as of #72
^ note that those get_fields
lines are actually covered...there are two scrolling strategies (one for new, one for legacy), and only one of the two gets covered in any single set of tests (on a single ES version). They're both covered because our CI stuff tests over many versions
from uptasticsearch.
so our coverage is above 97%! Those last few lines would be real real hard to cover, but someone is welcome to take this up if they really want
from uptasticsearch.
If you want to contribute on this, here's how you can check the test coverage:
- Spin up Elasticsearch locally and seed it with data. This requires that you have
docker
running
./setup_local.sh 6.2
- Install the package and run the R tests
make install_r
make coverage_r
You should see something like this in the terminal
and a file coverage.html
should open in your default web browser. That file shows detailed information on which files have untested code and which lines specifically are untested.
-
Add tests in
R-package/tests/testthat
and repeat step 2 -
When you're done, be sure to clean up your local environment
./cleanup_local.sh
PRs that add any test coverage are welcomed! You do not have to get to 100% in one shot.
from uptasticsearch.
Related Issues (20)
- CI is broken with Java issues again HOT 1
- Release Python client on PyPI
- Bad substitution in setup_local.sh
- multi-line blocks in roxygen documentation should be aligned to the first non-tag word
- Add linting on R code
- standardize directory names on kebob-case HOT 2
- Add 'covr' to Suggests in the R package HOT 2
- Unnecessary numbering in comments
- Add lifecycle badges to README
- Add codecov badge to the README HOT 1
- docs style: inline mentions of functions should use parentheses HOT 2
- Make README examples copy-paste runnable
- explicitly add language tags to all markdown code blocks HOT 1
- hex logo HOT 5
- Replace use of 'ES' with 'Elasticsearch' everywhere in the repo
- problems with certificate HOT 4
- [ci] Move CI from Travis to GitHub Actions HOT 2
- How to enter password and username in to the es_host HOT 3
- How to enter API key to connect to elastic instance HOT 1
- R tests using deprecated testthat functionality
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from uptasticsearch.