Giter Club home page Giter Club logo

Comments (5)

bfulton avatar bfulton commented on July 20, 2024

@dharmamike thanks! Is your use case satisfied by the changes in #82?

from docker-api.

dharmamike avatar dharmamike commented on July 20, 2024

It appears the changes to image.rb in that PR would still result in the search data being lost as it only passes a hash containing the image name as the value of the id key rather than the entire search result hash.

https://github.com/swipely/docker-api/pull/82/files#diff-cc34058b2ca3f4a25492ec3a62e4420fR125

from docker-api.

bfulton avatar bfulton commented on July 20, 2024

If #82 is merged, we could change #search to do something like:

hashes.map { |hash| new(connection, hash.merge('id' => hash['Name'])) }

Right?

from docker-api.

dharmamike avatar dharmamike commented on July 20, 2024

That seems like it would work just fine, yeah!

from docker-api.

bfulton avatar bfulton commented on July 20, 2024

@dharmamike #82 is merged. Can you submit a pull request for this?

from docker-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.