Giter Club home page Giter Club logo

Comments (8)

serickson67 avatar serickson67 commented on September 9, 2024 1

I'd like to work on this, will you assign it to me?

from react-todo.

kamalkishor1991 avatar kamalkishor1991 commented on September 9, 2024 1

@serickson67 great. Thanks

  1. It should move to add item also.
  2. No I don't think circular make sense.

from react-todo.

kamalkishor1991 avatar kamalkishor1991 commented on September 9, 2024 1

@serickson67 thanks for helping out with this. Merged the PR and closed the ticket.

from react-todo.

serickson67 avatar serickson67 commented on September 9, 2024

Thanks, I'm on it!

from react-todo.

serickson67 avatar serickson67 commented on September 9, 2024

Hi - I've made some good progress on this, but have some questions about how you would like certain cases to behave:

  • Do you want the up arrow key to allow the cursor to move just between the created ToDoItems or should it also allow you to arrow up into the 'Add Item' text field?
  • Do you want the up arrow/down arrow to be circular? Meaning, if the cursor is at the top of the list of items, and you hit the up arrow it will move the cursor to the bottom? And vice versa for the down arrow at the bottom of the list of items.

from react-todo.

serickson67 avatar serickson67 commented on September 9, 2024

Please review my pull request: #41

from react-todo.

serickson67 avatar serickson67 commented on September 9, 2024

Hey - I linked my pull request above, but it doesn't seem linked to this issue. Sorry, I'm fairly new to contributing to open-source projects, could you tell me how I should have linked it?

from react-todo.

serickson67 avatar serickson67 commented on September 9, 2024

Hey - please don't forget to review my pull request with the updates - and also, can you please add the hacktoberfest label to this issue and the pull request so I can get credit there? I appreciate it. @kamalkishor1991

from react-todo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.