Giter Club home page Giter Club logo

Comments (1)

gatoWololo avatar gatoWololo commented on September 2, 2024 1

I think a good way to implement this is as an enum of possible failure reasons:

enum CacheMissReason {
  BinaryMismatch,
  EnvVarMimsmatch,
  OutputFileChanged(PathBuf)
}

Notice you can even add the reason why it failed as "metadata" to the enum variant as data. Like in the OutputFileChanged example. We can give it the path of the offending file.

Then as you do your checks you can have a miss_reasons: Vec<CacheMissReasons> of why things fail thatt you append to:

miss_reasons.push_back(Foo)

And print them at the bottom by printing the Vec.

I know Joe didn't think it was super necessary, but I think it is clean, and later it if/when we add testing we can check the reasons why things fail match the expected reasons why things fail! The logic for checking for hash hits in nontrivial. So it would be nice to have tests for it. Specially since it will only get more complicated later.

from processcache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.