Tasks not handled correctly about embedio HOT 6 CLOSED

I am reopening this issue because and marking it as an enhacement to change calls that can be changed to ConfigureAwait(false) i.e. those that don't require context. Are there any other specific recommendations that you might want to suggest @kdblocher ?

from embedio.

Do you have a pull request that we may use to implement your proposed changes?

from embedio.

I can see if I can put one together. I thought it might be at least useful for you guys to read up about this topic, since the pattern is becoming a lot more commonplace.

from embedio.

There are still several problematic uses of Task.Factory.StartNew and sync-over-async antipatterns throughout the code, but I don't think they're fixed easily (from the outside). I still suggest you take a look through the blog (for that matter, any of Stephen Cleary's writing) and read some of the common suggestions. Most are applicable in your case.

See http://stackoverflow.com/a/36355946 and https://msdn.microsoft.com/en-us/magazine/jj991977.aspx for more information.

from embedio.

@mariodivece yes: follow the "async is viral" approach - e.g. everything lower-level that is asynchronous should be called by asynchronous methods itself. This is the most performant, and the cleanest. (I actually tried to do this with your code but ran into a couple of pitfalls.)

I can add a couple of commits with small changes to demonstrate.

from embedio.

@kdblocher check my latest commits, I've been updating the code to a better async/await approach.

from embedio.