feat: Add support for specifying HttpClientHandler about unleash-client-dotnet HOT 8 CLOSED

Argh I spoke too soon. you are indeed correct, it's all coming back to me now 😬

from unleash-client-dotnet.

Brilliant, good to hear @christianfosli ! 2.4.0 release just went out with the fix for this, so should be safe to close now at least. I'll close with a comment. Meant to mention this properly in this issue before it was closed anyways.

from unleash-client-dotnet.

@christianfosli

You could inherit the Unleash.DefaultHttpClientFactory instead of the Unleash.IHttpClientFactory. There's a couple of extension points in that which could serve your purpose, for example if you override the ConfigureHttpClient() method

from unleash-client-dotnet.

Thanks for the suggestion 😄
I looked at that, but as far as I can tell the HttpClientHandler must be supplied to HttpClient's constructor and can't be added/edited after instantiation.

from unleash-client-dotnet.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from unleash-client-dotnet.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from unleash-client-dotnet.

I'm happy with the PR #119 solution for this 😄 Thanks!

Should leave the issue open until 2.4.0 stable release is out?

from unleash-client-dotnet.

Added a feature to address this with PR #119 in release 2.4.0.
Documentation: https://github.com/Unleash/unleash-client-dotnet#httpmessagehandlerscustom-httpclient-initialization

from unleash-client-dotnet.