Giter Club home page Giter Club logo

Comments (4)

ciro-unity avatar ciro-unity commented on May 5, 2024 1

Hey @Tatranskymedved! Welcome to the project :)
Have you followed the exact steps?

For clarification, when I say dynamic objects I mean not static. But they don't need to be SkinnedMeshRenderers. Both SkinnedMeshRenderer and MeshRenderer create the issue.

from open-project-1.

Tatranskymedved avatar Tatranskymedved commented on May 5, 2024

I'm not that experienced in Unity so I'm trying my best by test-failure errors, I'm warning that my founding might not be clear/make sense 😉 :

For dynamic objects: we're using Skinned Mesh Renderer which doesn't support lightmap (they will be always dark without direct light?) - https://forum.unity.com/threads/problem-with-skinned-mesh-renderer.366293/

However I've played around with static objects, I've found that when I've set constant color in shader to value 1 (Shaders/CustomHLSL/CustomLighting.hlsl), objects get proper color. I assume that the light at the position of that object has wrong color (black?) and thus it doesn't enlighten it.

I'd like to follow up on fix, but I would need some more hint what can be wrong & what to check. Thanks.

from open-project-1.

Tatranskymedved avatar Tatranskymedved commented on May 5, 2024

Hi @ciro-unity , I've added PR, once you have little time, could You please review it & confirm if we want to do it this way and if we want light on all objects or just the static/with Baked GI? Thanks!

from open-project-1.

treivize avatar treivize commented on May 5, 2024

@Tatranskymedved, regarding this issue, I think that the smallest impact needed to fix it without having to use branch should be:

image

(Backed GI) -> (one minus) -> (Step with edge to 1) will out 1 only if Baked GI will be zero and out 0 for any other value. So adding this value to the initial Backed GI node will force Backed GI to return a default value (1) if Backed GI is not defined.

Result from a brand new Default Scene:
image

from open-project-1.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.