Comments (6)
I definitely know what's wrong with the indicated resolution, should have a fix for that shortly.
The scaling always showing 1 is interesting. Can you tell me which version of Unity, which render pipeline, and if it's an SRP which version?
from dynamicresolutionsample.
Unity 2021.3.9f1 with HDRP 12.1.7. I am on macOS but I think I saw it on Windows too.
from dynamicresolutionsample.
I definitely think something is wrong in general – it bounces around at the very bottom of the range and never uses really much of the resolution. It also does not seem to respect my target frame rate setting and always seems to optimize for the display refresh rate.
Maybe it is a misconfiguration? Or that issue where macOS/Metal reports weird timings?
from dynamicresolutionsample.
I believe the core issues are resolved in fceaae5. Resolution should be correct in fullscreen and windowed, current scale should be the actual scaling value. Tested on your version of Unity and HDRP on Windows. I assume it's also fixed on Mac, but I'll be checking that shortly as part of validating your PR.
RE: the additional issues mentioned in your last comment. I think I understand what's going on, but let me know if I've missed the mark and we need to investigate this further.
For scaling behavior, I think it can be attributed to timing data being spikier on Mac/Win than other platforms, leading to two core problems. First is that it can be more common to get a long frame and trigger a scale down, which would require some rewriting to address. The second is that it takes too long to scale up when the timings are more volatile, and for this the script was written to have some tunable params to change the aggressiveness of scaling up. So I'd suggest trying to tune those values to get better behavior; the ReadMe is hopefully a suitable guide if there are any questions. It won't fix the entire problem as you'll still be at the mercy of long frames triggering scale downs, but it should be possible to be scaling up more and faster to improve the overall average resolution you're seeing.
For framerate, have you either modified the script to utilize a different target framerate or called SetTargetFramerate at runtime? The script starts up by default targeting 60fps so out of the box it would not be expected to see any other behavior.
from dynamicresolutionsample.
Thanks! I'll check that out. Yes, I was calling SetTargetFramerate
with various settings.
from dynamicresolutionsample.
If you want to open a separate ticket and include as much relevant info as you can about the target framerate issue, I'll try to look into it when I get some time.
from dynamicresolutionsample.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dynamicresolutionsample.