Don't use an address when you mean an interface. about v2-core HOT 2 CLOSED

spoke with @haydenadams about this, we're leaning towards not doing it to avoid having inter-interface dependencies (e.g. IUniswapV2Factory would need to rely on IUniswapV2), as well as for enhanced clarity on the data types of variables (as opposed to their function). going to leave the issue open though for further thought!

from v2-core.

avoid having inter-interface dependencies

The following is valid Solidity:

interface IApple {
    function color() external returns (address);
}
interface IColor { }
contract Apple is IApple {
    IColor public color;
}

You could follow a pattern like this to avoid inter-interface dependencies.

enhanced clarity on the data types of variables (as opposed to their function).

Opinion: The most "clear" code in terms of what it actually does is assembly, but such code is also the most unreadable. In my experience, readable code will result in fewer bugs than "clear" code, so should be preferred unless there is a strong argument against readability. In this case, the code is more readable if the type information expresses what exactly is being mapped, and it gives you the added benefit of giving additional compiler checks (another great reducer of bugs).

from v2-core.