Giter Club home page Giter Club logo

Comments (6)

monnand avatar monnand commented on June 8, 2024

This is a good point! Let me see if I can make this change in next week. It should not be very hard.

from uniqush-push.

mishan avatar mishan commented on June 8, 2024

Hm, I don't see why not. 👍 for the idea

from uniqush-push.

mishan avatar mishan commented on June 8, 2024

@tleyden I bet then it would also be nice for you to have APNS pems stored inside Redis instead of on the file system?

from uniqush-push.

tleyden avatar tleyden commented on June 8, 2024

@mishan just curious, would that be for security reasons or ease of use?

from uniqush-push.

mishan avatar mishan commented on June 8, 2024

Ease of use -- I haven't found it totally convenient to host it on the filesystem either. It's not ideal to store blobs of data in Redis but it's small and there shouldn't be too much of it that it should be OK. The Redis best practice is indeed to store the path as it is doing now.

from uniqush-push.

TysonAndre avatar TysonAndre commented on June 8, 2024

It's easy to do, but there's other ways to accomplish this, and not sure if this is a common use case.

An alternative is to use a volume to add a folder with the certificates, or files with the certificates.

curl http://path/to/remote/uniqush-push.conf -o ~/path/to/uniqush-push.conf || exit 1 (or equivalent) could be used as another alternative in a startup script wrapping uniqush-push, so it seems unnecessary to include it (other services, such as redis, memcached, etc. don't generally download configs from a URL, to my knowledge).

https://docs.docker.com/engine/admin/volumes/volumes/#choose-the--v-or-mount-flag

Also,

I bet then it would also be nice for you to have APNS pems stored inside Redis instead of on the file system?

#123 would have to be solved first.

from uniqush-push.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.