Giter Club home page Giter Club logo

Comments (8)

mariuswilms avatar mariuswilms commented on May 28, 2024

So the inRange validator with options lower set to 5 and upper to 10 in exclusive mode should match 3 and 11 but not 7?

from lithium.

kszucs avatar kszucs commented on May 28, 2024

No.

inRange with lower => 5 and upper => 10 in exclusive mode should match
between 6 and 9
inRange with lower => 5 and upper => 10 in inclusive(exclusive=>false)
mode should match between 5 and 10

I think what You thinking about is notInRange validator.

On 09/05/2011 03:36 AM, davidpersson wrote:

So the inRange validator with options lower set to 5 and upper to 10 in exclusive mode should match 3 and 11 but not 7?

from lithium.

mariuswilms avatar mariuswilms commented on May 28, 2024

Thanks for your explanation. I don't see a why you can't achieve this by specifying lower 6 and upper 9 when it does what you want. Seems clearer to me, wouldn't require reading about/documenting an additional feature and is more straightforward. I'm closing this for now, anybody who has a stronger feeling about implementing this can reopen the ticket.

from lithium.

kszucs avatar kszucs commented on May 28, 2024

How can I validate integers (without decimal digits) with the default
validators?

I think it makes sense when using floats.
I can't validate floats with 'decimal', only fixed point numbers.
If I want to validate float between 2.71 and 3.14 inclusively I would
probably use the following validators:
'decimal' without precision option, this will validate that the
value is really a float number
'inRange' with lower 2.71 and upper 3.14
currently it won't match the limits
as You said I can extend a range to 2.70 and 3.15 but it still
matches 2.701 or 2.7000345 or 3.1486578563

Do You see my problem?

On 09/05/2011 03:00 PM, davidpersson wrote:

Thanks for your explanation. I don't see a why you can't achieve this by specifying lower 6 and upper 9 when it does what you want. Seems clearer to me, wouldn't require reading about/documenting an additional feature and is more straightforward. I'm closing this for now, anybody who has a stronger feeling about implementing this can reopen the ticket.

from lithium.

joebeeson avatar joebeeson commented on May 28, 2024

Couldn't the issue @threestan is seeing be resolved by instead switching the isRange validator to be inclusive all the time?

from lithium.

nateabele avatar nateabele commented on May 28, 2024

@threestan I don't think this is common enough to warrant patching the core. What's wrong with just adding a custom validation rule in your app?

from lithium.

kszucs avatar kszucs commented on May 28, 2024

Sure, I did so.
IMHO inclusive is the expected behavior

from lithium.

nateabele avatar nateabele commented on May 28, 2024

Finally getting caught up here. @threestan I'm fine with inclusive being the default behavior here. If you're willing to provide a patch and a test case in a PR against the dev branch, we'll get it into core.

from lithium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.