Comments (11)
More information is needed on this as was mentioned in IRC. The All related code (Model, Query etc) must be provided to help better figure out what's going on. A dump of sample MySQL data would be helpful as well.
from lithium.
I get it also. Seems any find with associated model where the only condition is a pk of the main model that doesnt exist in the table will cause this problem.
from lithium.
Interesting. @alkemann or @davidgolding, can one of you submit a small sample of reproduce code (even if not a full test case), so we can get going on this? Just want to make sure we're fixing the right bug, and that it doesn't show up again.
Thanks, guys!
from lithium.
[paste removed, no good url] - /clients/view/1 - works fine, while any value of {:id} other than 1 will cause the sql bug
from lithium.
I was able to replicate the behavior using li3_microblog (see my github) but does not break SQLite.
A way to fix this would be to stop querying the database engine if the first query does not return any records.
from lithium.
As far as I can tell, this behavior is happening in \lithium\data\source\Database::read()
around lines 282-288:
https://github.com/UnionOfRAD/lithium/blob/master/data/source/Database.php#L282-288
I may be missing where the adapter could be calling for the additional query, though.
from lithium.
https://gist.github.com/37fb48e331050cb8cae2
This is what I've used to replicate the error. Going to /posts/view/1 succeeds, but like alkemann's example, any other {:id} value that doesn't match a record in the posts
table will return the SQL error.
from lithium.
Does this pull request resolve the issue?
from lithium.
Yes, a test case also exists for that. Sorry I looked over this ticket.
from lithium.
@david, if you have any further issues please do let me know.
from lithium.
Fantabulous. Excellent, thanks.
from lithium.
Related Issues (20)
- Cache problem? HOT 2
- Fatal error: Cannot use 'Object' as class name as it is reserved in D:\xampp\htdocs\li3app\libraries\lithium\core\Object.php on line 37 HOT 1
- How to set the "base" of the environment/request
- couchdb 2.3 is not working with lithium HOT 1
- li3 2.0 trait not found HOT 2
- Remove {Static,}Object for Shallow Class Hierachy HOT 1
- PHP 7.3 compact() E_NOTICE HOT 3
- Cant find instructions on how to install the program HOT 1
- Question: Support PHP 7.4 HOT 2
- Unable to use JSON query operands in fields list
- Framework status? HOT 1
- Maintainer/s wanted HOT 1
- Framework upgrade for latest PHP HOT 4
- add devcontainer configuration
- implement CI with GitHub Actions
- li3 upgrade to php 8 HOT 7
- BUG: Model::find() returns false instead of empty RecordSet HOT 3
- 'with' count 1, not 0
- AND Post.id IN () HOT 1
- PHP 8.3 compatibility HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lithium.