Giter Club home page Giter Club logo

Comments (11)

Howard3 avatar Howard3 commented on May 29, 2024

More information is needed on this as was mentioned in IRC. The All related code (Model, Query etc) must be provided to help better figure out what's going on. A dump of sample MySQL data would be helpful as well.

from lithium.

alkemann avatar alkemann commented on May 29, 2024

I get it also. Seems any find with associated model where the only condition is a pk of the main model that doesnt exist in the table will cause this problem.

from lithium.

nateabele avatar nateabele commented on May 29, 2024

Interesting. @alkemann or @davidgolding, can one of you submit a small sample of reproduce code (even if not a full test case), so we can get going on this? Just want to make sure we're fixing the right bug, and that it doesn't show up again.

Thanks, guys!

from lithium.

alkemann avatar alkemann commented on May 29, 2024

[paste removed, no good url] - /clients/view/1 - works fine, while any value of {:id} other than 1 will cause the sql bug

from lithium.

masom avatar masom commented on May 29, 2024

I was able to replicate the behavior using li3_microblog (see my github) but does not break SQLite.

A way to fix this would be to stop querying the database engine if the first query does not return any records.

from lithium.

davidgolding avatar davidgolding commented on May 29, 2024

As far as I can tell, this behavior is happening in \lithium\data\source\Database::read() around lines 282-288:

https://github.com/UnionOfRAD/lithium/blob/master/data/source/Database.php#L282-288

I may be missing where the adapter could be calling for the additional query, though.

from lithium.

davidgolding avatar davidgolding commented on May 29, 2024

https://gist.github.com/37fb48e331050cb8cae2

This is what I've used to replicate the error. Going to /posts/view/1 succeeds, but like alkemann's example, any other {:id} value that doesn't match a record in the posts table will return the SQL error.

from lithium.

davidgolding avatar davidgolding commented on May 29, 2024

Does this pull request resolve the issue?

#106

from lithium.

Howard3 avatar Howard3 commented on May 29, 2024

Yes, a test case also exists for that. Sorry I looked over this ticket.

from lithium.

Howard3 avatar Howard3 commented on May 29, 2024

@david, if you have any further issues please do let me know.

from lithium.

davidgolding avatar davidgolding commented on May 29, 2024

Fantabulous. Excellent, thanks.

from lithium.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.