StaticObject - forward_static_call_array about lithium HOT 8 CLOSED

I think the big difference is that the static method checks for Late Static Binding while the "old" method does not. I think this is an interesting question and nate should comment on how we would benefit from this or not?

edit: actually it could be possible that call_user_func_array also checks for lsb since 5.3.. hm...

from lithium.

Ha, if late static binding is supported in call_user_func_array, then why would they add forward_static_call_array? Seems quite redundant...

Not doubting you btw, just wondering what they were thinking if that's the case :-)

from lithium.

Actually it is the LSB part. This returns "BA" and shows the difference.

<?php

class A {

    public static function who() {
        echo __CLASS__;
    }

    public static function test() {
        echo static::who();
    }
}

class B extends A {

    public static function who() {
        echo __CLASS__;
    }

    public static function test() {
        forward_static_call(array('A', 'test'));
        call_user_func(array('A', 'test'));
    }
}

B::test('foo');

?>

from lithium.

So does that suggest that it's better to use forward_static_call or call_user_func in this scenario?

from lithium.

I think we should give it a try and see if all test cases pass. If they do, let's consider it on IRC with the core devs and choose what makes sense.

from lithium.

Update: I don't get any failing tests with this enhacement. Can someone crosscheck before we push it to master?

from lithium.

Did log behavior change any? Such as referencing which class called a
method? I think this change would only alter the value of get_called_class.

• Jon Langevin -- sent from my Android phone
  On Jul 7, 2011 9:10 AM, "daschl" <
  [email protected]>
  wrote:

  Update: I don't get any failing tests with this enhacement. Can someone
  crosscheck before we push it to master?

  --
  Reply to this email directly or view it on GitHub:
  #23 (comment)

from lithium.

This ticket has been merged into master, thanks again!

from lithium.