Comments (5)
Both of these issues (encoding and links to docs) should be fixed in 4.6.x
and 5.0
now. Thank you again for your report!
from thredds.
It also happens for spaces in the path. For some reason the GET includes %2520 instead of %20 for spaces.
from thredds.
There is some javascript used in the OPeNDAP html data access page that makes a web request when you click "Get Binary" or "Get ASCII", and that code makes sure to encode the URL before making those requests. It currently encodes the entire URL, but it looks like it should only encode the query portion of the URL. What happens is the percent sign in the encoded space gets encoded a second time (to %25
) on submission. It should be a relatively simple fix though. Thanks for the report!
from thredds.
Thanks for your feedback! I think that this is indeed the issue.
The javascript code in the HTML page:
function ascii_button() {
var url = new String(document.forms[0].url.value);
var url_parts = url.split("?");
/* handle case where constraint is null. */
if (url_parts[1] != null) {
var ascii_url = url_parts[0] + ".ascii?" + url_parts[1];
}
else {
var ascii_url = url_parts[0] + ".ascii?";
}
window.open(encodeURI(ascii_url), "ASCII_Data");
}
I guess that only url_parts[1]
should be encoded (as you mentioned).
In the download form, Action, Data URL, Global Attributes, Variables are (currently) broken links to like links these:
https://www.opendap.org/online_help_files/opendap_form_help.html#data_url
I was wondering if you were aware of this.
Thanks again for your help!
from thredds.
This is great! Do you have already an idea when will be a release with this fix? Thanks a lot!
from thredds.
Related Issues (20)
- Possible loop in thredds.client.catalog graph?
- Possible Issue with logging ResponseSize caused by insufficient storage type HOT 4
- variable attributes showing up in OPeNDAP global attributes! HOT 8
- Performance Issue with high variable and dimension count
- Thredds do not behave well behind Nginx proxy serving as SSL termination HOT 4
- Question regarding WCS DescribeCoverage ResponseCRSs HOT 4
- Wrong URL in description of this repository HOT 1
- Cross-Origin Read Blocking (CORB) blocked cross-origin response thredds HOT 2
- EOFException on NCDump data
- DAP4 in TDS dap4.core.util.DapException: Resource root not found HOT 3
- WMS GetMap Request with style=contour Returns Error HOT 14
- Unexpected behavior when querying area around Meridian HOT 2
- Date truncated by cast to long HOT 7
- NCML Time axis aggregation with missing / time gaps HOT 6
- trimDirectiveWhitespaces breaking GetTransect HOT 3
- Unsigned types in NcML
- Tracking log4j security issues HOT 10
- blank Godiva2 basemap HOT 1
- WMS service broken in 4.6.19+ HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thredds.