Giter Club home page Giter Club logo

Comments (10)

unicfdlab avatar unicfdlab commented on August 26, 2024

Hello, thank you for the feedback. We have reviewed our code several time and I don't think it contains severe errors, but I'll be happy to verify it again with you.
Meanwhile, FWH must be applied to the 3D sphere (without any symmetry assumptions) if you want to validate the implementation using the monopole source. Can you post here the description of your test case?

from libacoustics.

wyj216 avatar wyj216 commented on August 26, 2024

Hello, thank you for the quick response. I hope, it is my fault. I used the branch for OF-V1912. The mentioned case is a case in the tutorial, i.e. monopole 1D. In this tutorial, without changing anything, Farassat1AFormulation is used, and there is also symmetry assumption in this case. That might be the reason why there is inconsistency between postProcessing/probes/0/p and acousticData/monopoleFwhTest-time.dat, I mean the amplitude, not the absolute value.

Regarding the formula, I will try to find out some references and discuss it here later.

from libacoustics.

wyj216 avatar wyj216 commented on August 26, 2024

Hello, there are too many sources for the formula, and the symbol meaning could be different. Here I take a summary document of F. Farassat as the reference, i.e. "Derivation of Formulations 1 and 1A of Farassat". https://ntrs.nasa.gov/archive/nasa/casi.ntrs.nasa.gov/20070010579.pdf
However, we can use any reference as you prefer. In this document, for example, equations (67) and (68) are the final formulas. For the calculation of p'T (qds in the code), in the second part, OneByOneMrSq * OneByOneMr should be divided, but in the code, it is multiplied (line 204 in Farassat1AFormulation.C). The same for fpart1, fpart2, fpart3.
Also, in this document, dot(vn) is already, dot v*n + v * dotn, als dotUn in the code, then there is no more v * dotn. In the code, there is still (U & dotn), it seems that it has been included twice.
I hope it is my misunderstanding somewhere. I just want to help if possible, and not mean to critisize. I really appreciate your effort to develop such a meaningful library.

from libacoustics.

unicfdlab avatar unicfdlab commented on August 26, 2024

OneByOneMrSq * OneByOneMr should be divided, but in the code, it is multiplied

OneByOneMr is 1/(1 + ....). That's why I multiply by this term

from libacoustics.

wyj216 avatar wyj216 commented on August 26, 2024

OneByOneMrSq * OneByOneMr should be divided, but in the code, it is multiplied

OneByOneMr is 1/(1 + ....). That's why I multiply by this term

Exactly! sorry, that's really my misunderstanding.

from libacoustics.

unicfdlab avatar unicfdlab commented on August 26, 2024

dotUn in the code is already dotU & n + U & dotn, the meaning is not the same as in the popular formula. The same for dotMr, dotlr.

Regarding this issue you are right - I will correct the source code and will come back in few minutes

from libacoustics.

unicfdlab avatar unicfdlab commented on August 26, 2024

Yes, you are correct, I have updated the source code (see also attached paper with designations, similar to the source code - https://arc.aiaa.org/doi/abs/10.2514/6.2010-3711). Nevertheless, these corrections don't make sense to your test case, because they work only for moving observer or moving control surface

from libacoustics.

unicfdlab avatar unicfdlab commented on August 26, 2024

Thank you for reviewing the code

from libacoustics.

wyj216 avatar wyj216 commented on August 26, 2024

Yes, you are correct. These corrections do not make sense to my test case. Now I am running monopole 3D case. I will check the result with the real 3D calculation.

from libacoustics.

wyj216 avatar wyj216 commented on August 26, 2024

I have tried the monopole 3D tutorial. The result is satisfactory, although discrepancy due to numerical error exits. Thank you again for your code and response!

from libacoustics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.