Giter Club home page Giter Club logo

Comments (4)

UnderMybrella avatar UnderMybrella commented on July 30, 2024

Unfortunately, I've been unable to reproduce using the two links provided. In both cases, in Firefox and Chrome, the song completed successfully. The only way I was able to reproduce was by pressing "Bring it home".

Could you try again, and if it persists check back in? If you can find any other songs that exhibit this behaviour, that would be welcome too.

from eternaljukebox.

Bendito999 avatar Bendito999 commented on July 30, 2024

Clarification: When playing normally it loops properly, but after manually seeking the track by clicking around, or using the arrow keys to change the speed, the top of the song stops playback. Load up the song and press the right arrow key multiple times (lower the branching to save time)
https://eternal.abimon.org/jukebox_go.html?id=2CzipbXgzWvnoFfLUEge9O&thresh=2&bp=0,0,0
The "Stop" button remains displaying "Stop", while if it was properly stopped, it would display "Play".
Perhaps this is the intended operation, but it seemed strange to me. Also tested with same results on Firefox.

from eternaljukebox.

UnderMybrella avatar UnderMybrella commented on July 30, 2024

To clarify, do you mean if you manually seek beyond the final branch? The only way I could get it working with that link, for instance, was if it skipped over the branch, either by not "hitting" it due to an increased speed or by seeking beyond that point.
If so, that's unintentional, yes, and I'll see what I can do.

from eternaljukebox.

Bendito999 avatar Bendito999 commented on July 30, 2024

Yes, manually seeking beyond the final branch, as it is forced to follow the final branch when running automatically (which is an intentional decision as the song wouldn't sound right in infinite mode after passing the top). Really the only application where the current stopping behavior is awkward is when changing speeds with the arrow keys and going past the final branch, as the song then stops at the top instead of still continuing. Top should stop song only when "bring it home" is active, else play from beginning. Really, upon further reflection, this is not very important, and I'm not sure if changing the behavior would have unintended consequences for users used to seeking towards the end to stop the song. I'll close the issue, thanks for looking into it though.

from eternaljukebox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.