Giter Club home page Giter Club logo

Comments (5)

tkrullmann avatar tkrullmann commented on August 11, 2024

Hi, and thanks for the contribution!
I've been meaning to look at the new configurations from the java-library plugin, and ensure the compatibility.

But I'm afraid it isn't going to be this easy. Apart from backward compatibility with pre-3.4 Gradle versions, there are plugins for other languages (esp. Groovy and Kotlin) that are reportedly not working well with the new configurations, so you have no choice but falling back to compile and runtime. Given that many people will write their tests in Groovy, this has to be considered carefully.

In my opinion the Gradle team tends to be a bit rash with deprecation, often deprecating things that don't have a stable replacement yet. So I wouldn't put too much stock in compile and runtime being deprecated.

from gradle-testsets-plugin.

tobad357 avatar tobad357 commented on August 11, 2024

For future reference
Kotlin issues
https://youtrack.jetbrains.com/issue/KT-18497
https://youtrack.jetbrains.com/issue/KT-18544

Compatibility issues mentioned in Gradle docs
https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_known_issues_compat

from gradle-testsets-plugin.

alexkleiman avatar alexkleiman commented on August 11, 2024

I was able to work around this by adding the following to my Gradle build:

configurations {
    integrationTestImplementation {
        extendsFrom testImplementation
    }

    integrationTestCompileOnly {
        extendsFrom testCompileOnly
    }

    integrationTestRuntimeOnly {
        extendsFrom testRuntimeOnly
    }

    integrationTestCompileClasspath {
        extendsFrom testCompileClasspath
    }

    integrationTestRuntimeClasspath {
        extendsFrom testRuntimeClasspath
    }
}

This seems to do the trick for Java, at least.

from gradle-testsets-plugin.

tkrullmann avatar tkrullmann commented on August 11, 2024

The plugin now honors the implementation and runtimeOnly configurations when extending test sets, in addition to the compile and runtime configurations as before.

This is analogous to the configuration extensions that the java plugin creates for the "test" test set.

@alexkleiman
The compileOnly configurations should not be inherited, they are intended for optional and compile-time-only dependencies (like annotation processors). These dependencies are typically closely related to the source code of the respective source set. (The standard java plugin doesn't add and extension from testCompileOnly to compileOnly either).

Also, compileClasspath and runtimeClasspath are "derived" configurations, so adding these extensions should be unnecessary.

from gradle-testsets-plugin.

alexkleiman avatar alexkleiman commented on August 11, 2024

@tkrullmann got it, thank you for the details!

from gradle-testsets-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.