Object reference not set to an instance of an object on empty Vorto about umbraco-vorto HOT 9 CLOSED

I can confirm the problem.
In 1.5 GetVortoValue has changed its behaviour when the value of the specified culture in not set. Now throws an exception.

from umbraco-vorto.

@alecrt which line specifically are you referring to that has changed?

from umbraco-vorto.

Sorry @mattbrailsford didn't look at the source code still.

The exception thrown is "The given key was not present in the dictionary" and happens when a specific culture is passed as cultureName parameter in DoInnerGetVortoValue method.

So my guess is that something goes wrong here:

var bestMatchCultureName = vortoModel.FindBestMatchCulture(cultureName);
var value = vortoModel.Values[bestMatchCultureName];

from umbraco-vorto.

I've added some additional null checking to that area in DoInnerGetVorotValue (it should have actually been the same checks that occur in HasVortoValue but for some reason they were less restrictive) so hopefully this should fix it. There is a new release on the build server if you guys fancy giving it a try and letting me know if this fixes it for you?

https://ci.appveyor.com/project/mattbrailsford/umbraco-vorto/build/1.5.1.36/artifacts

Cheers

Matt

from umbraco-vorto.

I have upgraded to Our.Umbraco.Vorto.1.5.1-alpha-000036.nupkg and now it's fixed. Thanks for the quick response.

from umbraco-vorto.

Awesome! Thanks for reporting the issue.

from umbraco-vorto.

Thanks!

from umbraco-vorto.

I just upgraded from Vorto 1.5.3 to 1.6.0 and I get the same error again. Is it possible this somehow got reverted in the latest version?

from umbraco-vorto.

I have downgraded back to Vorto 1.5.3 and the error is gone. Could this issue be reopened?

from umbraco-vorto.