Comments (3)
As discussed I believe the issue here is we loop over and store the doctype name in the meta data and use that to build up the Claims key (ie "docType:Field:Permission" so "Homepage:pageTitle:read"). But when we use the contentBy stuff it doesn't have that meta data available. If we could get it injected in then it should "just work" but that would require that we do a look up to get the data (ie resolve it) before we check the authentication (which is currently done with a filter which fires before we resolve).
Bit of a chicken and egg situation.
from umbraco-graphql.
I guess the problem is that the validation rules is run against the query (which doesn't know the correct types).
One solution is to move the auth to a field middleware since they are run at execution time and at that point we know which type that's gonna be returned.
But if we #20 are getting implemented I'm not sure if this is gonna be a problem since you'll only get the schema you'll have access to and it'll just fail if you try to query for a field that "doesn't exist"
from umbraco-graphql.
Closing this for now as I've removed the permissions for now
from umbraco-graphql.
Related Issues (20)
- Custom fields not outputted in umbraco8 branch HOT 2
- Make umbraco8 the master branch HOT 1
- graphql endpoints HOT 1
- What's the syntax for filtering queries? HOT 2
- Umbraco 8 support? HOT 1
- Call for maintainers HOT 4
- Performance tests and benchmarks
- Security investigation
- Build pipeline and automated release
- Multi-lingual content and variants HOT 1
- Remove ToDos from README.md and move them into issues (if they still apply) HOT 3
- Support Dictionary Items
- Investigate similar solutions in other (open source) CMS
- Create Developer Documentation
- Support for Unicore HOT 3
- Revisit filtering
- Cannot access Rich Text field with Macro via GraphQL HOT 2
- Future of this project? HOT 4
- Exception when running with Umbraco 9.1.2 HOT 1
- V13 LTS update
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from umbraco-graphql.