Whitespace complains about multi-line if statements about whitespace HOT 9 CLOSED

The message it's giving is correct, as it's a leaing newline in this code block (anything surrounded by {}).

However I agree there is a case to be made about the readability, it would be interesting to see how this is handled in Go's source code. Sadly gofmt can't be used as an example since it doesn't seem to have an opinion about single newlines.

from whitespace.

I took a look at multi-line if statements in the Go source code. There were no cases with an extra newline. Half of them did have a comment after the if, which achieves similar readability.

from whitespace.

Can you link some cases? How did you find them? Is there a command-line way to search through a repo for multi line if statements?

from whitespace.

I used a simple grep command to find some cases:

grep -A5 "if .* &&$" $(find /usr/lib/go/src -name "*.go")

This command is not perfect as it misses many case, but I'd say there's plenty of examples with this one command

from whitespace.

Thanks. I used this grep statement on the Kubernetes repository. Similar to the Golang repository, they also do not seem to use any newline between conditionals and more code, which was honestly surprising to me.

With that said, there is still a case to be made for programmers preferring a newline here for easy readability. Should whitespace be updated to ignore this specific kind of newline?

from whitespace.

Ignoring the newlines sounds like a bad solution. It could lead to inconsistent code. A better solution would be to make a setting that gives a warning when there is no newline (or comment) after every multi-line if.

from whitespace.

That would be great, thank you.

from whitespace.

I added a setting for this feature and made a pull request on golangci-lint.

golangci/golangci-lint#723

from whitespace.

Thank you!!

from whitespace.