Comments (4)
I think we originally chose the native Sphinx style docstrings in reStructured format to avoid the use of an additional Sphinx dependancy (Napoleon).
I agree that the Google style looks nicer.
We are always keen to make improvements and take on advice.
When we started using Sphinx we just wanted something that works easily. Now that we have been using Sphinx for a while we are more comfortable in adding dependencies to the workflow so I think it is a good time to reconsider that original decision.
What I would be interested to know is can we have a mixture of Google and reStructured in the same project. If so then I imagine that we can transition gradually to the Google style
It is not the most exciting part of the project but I can see the benefits.
Readthedocs currently builds on just the develop branch so we might have to tinker with those settings as well to try this.
We use VScode to autogenerate the reStructured docstrings so that is not really an win for either option.
It also might be worth explaining why Google docstrings instead of PEP0257 or Numpy but I can see it is nicer than the reStructured
What are your thoughts @billingsley-john
from paramak.
@shimwell I'm not sure if Napoleon 🇫🇷 🍷 🧀 is handled like an actual dependency though. But @billingsley-john can certifies I don't understand much about how Sphinx works 😉
from paramak.
I will test whether a mixture Google and reStructured can be used in the same project. As mentioned by @shimwell, this would facilitate the gradual movement to Google-style over time
from paramak.
Docs now support both Google and reStructured/Sphinx styles. Added in #99
from paramak.
Related Issues (20)
- ToroidalFieldCoilPrincetonD R1 variable HOT 3
- TFCoilCasing vertical_section_offset HOT 2
- odd behaviour with port cutter center_point HOT 2
- TFCoilCasing does not use magnet workplane
- SALOME: a new open-source route for neutronics meshing ? HOT 3
- mbsize and mbconvert commands not found in dockerimage HOT 2
- updating the trelis / cubit scripts to run with system python
- develop branch requires openmc HOT 1
- tally using the volumes instead of materials
- adding parametric shape for sphere
- reactor.export_stp() to allow single stp file creation HOT 5
- plasma component not ignored in Reactor() class during simulation HOT 2
- cannot use same custom defined material for different components HOT 3
- unexpected keyword argument 'pf_coil_to_rear_blanket_radial_gap' HOT 1
- Look into alternative ways of running the notebook examples as tests
- Add docker instructions for developers in the docs HOT 1
- Tests fail with paramak:dependencies HOT 2
- Demo notebooks aren't showing anything HOT 2
- Readme Link Doesn't work HOT 2
- New Paramak repository
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from paramak.