parametric component points about paramak HOT 5 CLOSED

This hasn't been picked up because the parametric_component classes have their own points setter, rather than inheriting the points setter from shape.py

from paramak.

Some parametric_components still require last point=first point as they overwrite the setter which automatically adds the final point

from paramak.

Well spotted

from paramak.

The points getter and setter should not be overwritten in the parametric component classes. Instead, self.find_points() should be called immediately after the 'parametric parameters' (such as height, inner_radius etc) are set. I.e. self.find_points() does not have to be called as part of the points setter, meaning we can inherit the points getter/setter pair instead and make use of the points checks defined in shape.py

from paramak.

Resolved in #254

from paramak.