Comments (8)
I do know what base64 is :D. However, as far as I know GitHub doesn't allow/render base64 embedded images in issues because of security reasons. It could be an SVG with an embedded script tag after all. I'll double check that though.
The linked gist uploads the image directly to a git branch, which I will not support because that could easily turn into a security nightmare. It'll also need permissions for the auth token which would be really inappropriate for a tool like this.
from feedback.
It wouldn't be that hard. It would probably pretty similar to the already existing GitLab code.
Though GitHub currently does not support uploading images via its API. So there's not much value in doing it at the moment.
from feedback.
@ueman I tried to read myself into it, but from what I've gathered there was always the way of using base64 to upload an image to github.
Could you elaborate where thinks didn't work out, or which errors you had run into?
from feedback.
What exactly do you mean by uploading an image via base64? I'm not aware of it, so could you elaborate on it?
Could you elaborate where thinks didn't work out, or which errors you had run into?
I didn't run into any errors, GitHub just doesn't provide a way to upload images.
from feedback.
Sorry for the short answer, but I think this stackOverflow issue goes into detail how it could work and links to an existing js gist for such a case.
Without wanting to sound condescending, I do not know where to start explaining, bc base64 is quite the standard. An encoding standart for binary data that is. So you can basically convert any file into base64 and back, which makes it widely used for transfer (eg. image transfer).
For more info, see wikipedia π
Otherwise I am also more than willing to elaborate, I just don't know where to start π
from feedback.
I am delighted to hear that (and to be honest I would have been confused if you, who created such an amazing package, would not have known π )
How is your opinion of using a third party api for the image hosting (eg. imgur) and then just linking the image in the issue?
from feedback.
How is your opinion of using a third party api for the image hosting (eg. imgur) and then just linking the image in the issue?
I already thought about it, too. I'm not doing that because you would have to configure credentials for two services which would at least make me not wanting to use it myself. Using two services would also make GDPR compliance more difficult.
It's really a shame that GitHub doesn't support image uploads.
from feedback.
I personally would have nothing against setting up an additional service to be able to stay with github π.
But I totally understand the problem with the GDPR compliance π.
Also with imgur there would be the problem of possible deletion after 6 month.
from feedback.
Related Issues (20)
- Tabbing broken in dialogs HOT 2
- FeedbackSheetColor of lightTheme is applied in Darkmode HOT 1
- Adding vΓdeo recording HOT 2
- Cannot capture dialog HOT 1
- final image = await renderObject.toImage(pixelRatio: pixelRatio); issue HOT 6
- A better Template and Styling with Markdown for github , A new Package Required HOT 3
- Submit button seems to be cut off a bit
- Rearchitect BetterFeedback show>submit>pop Flow to Improve Dev Ex & Type Safety HOT 2
- Update to intl@^0.19.0 HOT 3
- Cupertino style HOT 7
- Backspace doesn't work HOT 5
- Color theme not apply after dialog
- Spanish language support HOT 2
- Difficulty drawing straight lines
- EasyLoading Dialog not working when showAlert
- Exception is not getting in try catch block HOT 3
- BlocBuilder getting error becuase of this widget. HOT 10
- Compatibility with riverpod ?
- Ability to provide custom onCloseFeedback function
- Update feedback_sentry to use sentry: ^8.0.0 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from feedback.