Giter Club home page Giter Club logo

Comments (14)

philippkuehn avatar philippkuehn commented on August 24, 2024 2

This is fixed in tiptap-extensions 0.16.3

from tiptap.

philippkuehn avatar philippkuehn commented on August 24, 2024 1

@childonline Yeah super strange. Didn't find anything until yet. The demo page setup is indeed different because I don't use the tiptap packages from npm. Instead I added some alias with webpack to grab these packages directly from the src folders of the repository. But I don't think that's what makes the difference.

from tiptap.

philippkuehn avatar philippkuehn commented on August 24, 2024

Can you provide a minimal test repo or an example at codesandbox.io?

from tiptap.

MihaitaN avatar MihaitaN commented on August 24, 2024

I can, hang on.

from tiptap.

MihaitaN avatar MihaitaN commented on August 24, 2024

Here you go: https://codesandbox.io/s/7ylzoylj10

from tiptap.

philippkuehn avatar philippkuehn commented on August 24, 2024

Hey I canβ€˜t find any drag and drop code in your example. πŸ‘€

from tiptap.

MihaitaN avatar MihaitaN commented on August 24, 2024

What do you mean? I just copied your example over from https://github.com/heyscrumpy/tiptap/blob/master/examples/Components/Routes/Images/index.vue .
It doesn't have any specific drag & drop logic, but I supposed the editor component already handles this.

Try opening the codesandbox on chrome and firefox and dragging and dropping an image from your machine onto the editor component (between Test & Text works best :) ).

On firefox the image gets loaded into the editor component, but chrome just opens a new tab with the image you dropped (it navigates to the file address on your machine).

PS: I'm using chrome 69.0.3497.100

from tiptap.

philippkuehn avatar philippkuehn commented on August 24, 2024

Ah sorry, my fault πŸ™ƒ

Hmm this is strange. Drop an image works fine on the official images example but not for your example on codesandbox. I'll check it out.

from tiptap.

childonline avatar childonline commented on August 24, 2024

Hey, it seems I stumbled over this exact same issue.

I'm also using chrome build 69.0.3497.100 and experiencing the same behavior.

The official image example does indeed work with chrome, but not when on localhost. Maybe it's something related to the build config of the examples page? I tried having a look, but couldn't find anything immediately obvious 😞 .

from tiptap.

childonline avatar childonline commented on August 24, 2024

I just noticed this issue also present on prosemirror, you can replicate the drag & drop behavior over at http://prosemirror.net/examples/dino/ . πŸ™ƒ So this is tehnically a ProseMirror issue not a TipTap issue.

But what really baffles me is why it works on chrome on the official images example.

from tiptap.

qyloxe avatar qyloxe commented on August 24, 2024

I would bet that it has something to do with headers, origin, feature detection, accept, https or anything else linked to browser-server context. Chrome has lately a "dark" history for implementation of those things and breaking many previously working use cases. Of course, it is done in the name of "security" so nobody should complain.

from tiptap.

philippkuehn avatar philippkuehn commented on August 24, 2024

This is strange. In this sandbox I import a custom ImageNode extension (it's a copy from the image extension from tiptap-extensions) and it works fine. So it seems that something goes wrong in the build process? πŸ€·β€β™‚οΈ

from tiptap.

childonline avatar childonline commented on August 24, 2024

Yup, I can confirm, loading an identical "custom" ImageNode works on localhost aswell.

from tiptap.

childonline avatar childonline commented on August 24, 2024

thx, mate!

from tiptap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.