Comments (14)
This is fixed in tiptap-extensions 0.16.3
from tiptap.
@childonline Yeah super strange. Didn't find anything until yet. The demo page setup is indeed different because I don't use the tiptap packages from npm. Instead I added some alias with webpack to grab these packages directly from the src folders of the repository. But I don't think that's what makes the difference.
from tiptap.
Can you provide a minimal test repo or an example at codesandbox.io?
from tiptap.
I can, hang on.
from tiptap.
Here you go: https://codesandbox.io/s/7ylzoylj10
from tiptap.
Hey I canβt find any drag and drop code in your example. π
from tiptap.
What do you mean? I just copied your example over from https://github.com/heyscrumpy/tiptap/blob/master/examples/Components/Routes/Images/index.vue .
It doesn't have any specific drag & drop logic, but I supposed the editor component already handles this.
Try opening the codesandbox on chrome and firefox and dragging and dropping an image from your machine onto the editor component (between Test & Text works best :) ).
On firefox the image gets loaded into the editor component, but chrome just opens a new tab with the image you dropped (it navigates to the file address on your machine).
PS: I'm using chrome 69.0.3497.100
from tiptap.
Ah sorry, my fault π
Hmm this is strange. Drop an image works fine on the official images example but not for your example on codesandbox. I'll check it out.
from tiptap.
Hey, it seems I stumbled over this exact same issue.
I'm also using chrome build 69.0.3497.100 and experiencing the same behavior.
The official image example does indeed work with chrome, but not when on localhost. Maybe it's something related to the build config of the examples page? I tried having a look, but couldn't find anything immediately obvious π .
from tiptap.
I just noticed this issue also present on prosemirror, you can replicate the drag & drop behavior over at http://prosemirror.net/examples/dino/ . π So this is tehnically a ProseMirror issue not a TipTap issue.
But what really baffles me is why it works on chrome on the official images example.
from tiptap.
I would bet that it has something to do with headers, origin, feature detection, accept, https or anything else linked to browser-server context. Chrome has lately a "dark" history for implementation of those things and breaking many previously working use cases. Of course, it is done in the name of "security" so nobody should complain.
from tiptap.
This is strange. In this sandbox I import a custom ImageNode extension (it's a copy from the image extension from tiptap-extensions) and it works fine. So it seems that something goes wrong in the build process? π€·ββοΈ
from tiptap.
Yup, I can confirm, loading an identical "custom" ImageNode works on localhost aswell.
from tiptap.
thx, mate!
from tiptap.
Related Issues (20)
- [Bug]: core/helpers/getMarksBetween is off by one when selection is empty HOT 2
- [Bug]: Bold Markdown input is broken when adding '__' at the beginning of a word (even in official demos) HOT 1
- [Bug]: why change isNodeEmpty behavior on a patch version? HOT 7
- [Bug]: Japanese IME input issue with multi-line selection in Tiptap editor HOT 1
- [Bug]: Copied paragraph with several <br> pasting into editor without last <br>
- [Documentation]: China has a huge market, why isn't there an official website with Chinese translation? **ζη巨倧εΈεΊοΌδΈΊδ½ζ²‘ζδΈζζζ‘£οΌ HOT 3
- [Bug]: It takes 2 Backspace presses to go back to last line due to trailing break created
- [Bug]: Missing <colgroup> Tag When Extending Tiptap Table with addNodeView Method Causes Resize Issue
- [Bug]: useEditor always creates at least 2 editors on mount HOT 8
- [Bug]: Typography extension's smart quotes are now broken HOT 1
- [Bug]: <col> element missing min-width (or width) style when column hasn't been resized HOT 2
- [Bug]: BubbleMenu not working, seemingly due to Tippy.js HOT 1
- [Bug]: handleKeyDown `Backspace` / `Delete` will not triggered when selection is not empty
- [Bug]: Youtube Extension: "https://www.youtube.com/live/[id]" cannot be embedded HOT 1
- [Bug]: linkify.init not called causing warnings in logs HOT 2
- [Bug]: Ellipsis input rule deletes previous character if triggered before a period HOT 1
- [Bug]: Markdown italics/bold shortcuts broken when used mid-sentence
- [Bug]: `UseEditorOptions` callbacks are incorrectly typed with CoreEditor arguments HOT 1
- [Bug]: Strikethrough doesn't respect font color HOT 2
- [Bug]: `onUpdate` called twice for each change HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tiptap.