Gracefully handle unknown providers about ueberauth HOT 10 CLOSED

For anyone who might need this, kinda obvious but in the meanwhile this can be done:

  plug :check_if_known_provider when action in [:request]
  plug Ueberauth

  @known_providers ~w(google)

  def check_if_known_provider(conn, _params) do
    provider = Map.fetch!(conn.params, "provider")

    if provider in @known_providers do
      conn
    else
      conn
      |> send_resp(400, "")
      |> halt()
    end
  end

from ueberauth.

I couldn't replicate the issue: #191

from ueberauth.

@yordis I think that's because all routes in the test router are defined explicitly, while we use this

scope "/auth", MyApp do
  pipe_through :browser

  get "/:provider", AuthController, :request
  get "/:provider/callback", AuthController, :callback
end

copied from ueberauth_google README

from ueberauth.

#193
Here is my proposed solution to the problem. It sets the error that can be handled in the the user callback and presets the status.

The question is:

• Do we remove the status set?
• Should we halt the connection?

This boils down to two solutions:

• Should we leave this error to be handled by the user?
• Should it always return 404?

Imo the visual way of handling this will depend on the application so I think I should remove the status and let the user handle the error however the library user wants.

from ueberauth.

I'd suggest raising an exception which implements Plug.Exception protocol, where the status is specified as 404.
In this case application will render a developer-defined error page.

from ueberauth.

That is a lovely idea, I will try to incorporate it.

from ueberauth.

from ueberauth.

I did push the proposal. Once it gets traction and gets approved I will write proper tests for this scenario.

from ueberauth.

@yordis sorry, but commit with the test you've merged doesn't solve the issue. It tests the following line

  get "/:provider", AuthController, :request

from ueberauth.

@fuelen I understand that it doesn't solve your problem, but that test failed with the changes that broke some people production code (which is the reason why I merged).

Another word, I am not proving that your situation is resolved.

from ueberauth.