Giter Club home page Giter Club logo

Comments (3)

ming1 avatar ming1 commented on July 22, 2024

Hi Ming,

There is no user of lib/ublksrv_aio.c now except demo_event.c. What about removing it from lib/ so that the library is simpler? I think related code can be moved into demo_event.c.

libnbd uses it:

https://github.com/libguestfs/libnbd/tree/master/ublk

Also the following project uses it too:

https://gitlab.com/amarjargal.gundjalam/qemu/-/blob/ublk_test1/block/export/ublk.c

BTW, lib/ublksrv_aio.c uses pthread_spin_lock(), eventfd()... which should not be included in a library.

Can you explain a bit why libublksrv can't use pthread_spin_lock(), eventfd()? The former is from libpthread, and the latter is one syscall.
I think it is pretty fine to include it.

But if you needn't it, I think it is fine to add config option to not
build ublksrv_aio.c into libublksrv.

thanks,
Ming

from ublksrv.

ming1 avatar ming1 commented on July 22, 2024

Such as, it can be done in the following way:

./configure --disable-io-offload

from ublksrv.

old-memories avatar old-memories commented on July 22, 2024

That's a good idea. Thanks Ming.

from ublksrv.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.