Giter Club home page Giter Club logo

Comments (9)

Droyk avatar Droyk commented on September 2, 2024 1

So after 7 years any updates?

from redditp.

ubershmekel avatar ubershmekel commented on September 2, 2024

In theory, yes. I wonder how this should work though. Perhaps I should show the first image and up/down arrows should appear when an album is displayed? I don't think redditp should just "inline" albums as more slides, though that would be the easy solution, because then large albums would steal attention from other images which got more karma juice per image.

from redditp.

ilydlci avatar ilydlci commented on September 2, 2024

I just got the following error when trying to display a Imgur album:

Uncaught TypeError: Cannot read property 'width' of null
at script.js:615
at Object.convert (EmbedIt.js:47)
at Object.embedit.embed (EmbedIt.js:126)
at createDiv (script.js:613)
at slideBackgroundPhoto (script.js:572)
at startAnimation (script.js:484)

Since the Imgur albums convertor calls the embedFunc callback with null.
I would call this an issue because although albums are not supported, the page should not break (instead it should show some error message and skip the unsupported link).

from redditp.

Droyk avatar Droyk commented on September 2, 2024

So what happened @ubershmekel will album option ever come?

from redditp.

ubershmekel avatar ubershmekel commented on September 2, 2024

I apologize, I realize albums are important and it's been a while. Especially for subreddits like /r/behindthegifs which are awesome. I would like to modify the way urls are converted to support many more kinds. Something like this: https://github.com/ubershmekel/urlpedia but I'm not yet quite sure about the details.

from redditp.

Droyk avatar Droyk commented on September 2, 2024

I can understand that but my question is when you are going to implement it?
If you are just going to wait around then it will be too late this feature was requested on 2012 and now it is 2017.....
it's been 6 years and you are still thinking....

from redditp.

 avatar commented on September 2, 2024

I think the best way to go about it, if you choose to work on this, might be to (as you said) display the first image, but have a separate redditp-like subapp (under redditp.com/a/..., perhaps) that just does a specific imgur album, and it could be opened with a particular hotkey.

from redditp.

ubershmekel avatar ubershmekel commented on September 2, 2024

I agree a hotkey or a button should just allow browsing through the album.

from redditp.

 avatar commented on September 2, 2024

@ubershmekel I might take a crack at adding imgur album support (just for browsing them at the moment) if you aren't already working on that.

from redditp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.