Comments (9)
So after 7 years any updates?
from redditp.
In theory, yes. I wonder how this should work though. Perhaps I should show the first image and up/down arrows should appear when an album is displayed? I don't think redditp should just "inline" albums as more slides, though that would be the easy solution, because then large albums would steal attention from other images which got more karma juice per image.
from redditp.
I just got the following error when trying to display a Imgur album:
Uncaught TypeError: Cannot read property 'width' of null
at script.js:615
at Object.convert (EmbedIt.js:47)
at Object.embedit.embed (EmbedIt.js:126)
at createDiv (script.js:613)
at slideBackgroundPhoto (script.js:572)
at startAnimation (script.js:484)
Since the Imgur albums convertor calls the embedFunc
callback with null
.
I would call this an issue because although albums are not supported, the page should not break (instead it should show some error message and skip the unsupported link).
from redditp.
So what happened @ubershmekel will album option ever come?
from redditp.
I apologize, I realize albums are important and it's been a while. Especially for subreddits like /r/behindthegifs which are awesome. I would like to modify the way urls are converted to support many more kinds. Something like this: https://github.com/ubershmekel/urlpedia but I'm not yet quite sure about the details.
from redditp.
I can understand that but my question is when you are going to implement it?
If you are just going to wait around then it will be too late this feature was requested on 2012 and now it is 2017.....
it's been 6 years and you are still thinking....
from redditp.
I think the best way to go about it, if you choose to work on this, might be to (as you said) display the first image, but have a separate redditp-like subapp (under redditp.com/a/...
, perhaps) that just does a specific imgur album, and it could be opened with a particular hotkey.
from redditp.
I agree a hotkey or a button should just allow browsing through the album.
from redditp.
@ubershmekel I might take a crack at adding imgur album support (just for browsing them at the moment) if you aren't already working on that.
from redditp.
Related Issues (20)
- Gfycat not automatically playing sound HOT 2
- A way to use this with OBS Browser Source? HOT 1
- Failed to handle redgifs url containing /ifr/
- Auto-next does not take into account the current time of any redgif video HOT 1
- redgifs v3 support HOT 6
- Not able to click the unmute button in redgif v3 in redditp HOT 4
- recent commit broke swiping to next item when video is playing HOT 2
- Cannot click image to view next HOT 3
- My favorite project is down :C HOT 1
- Audio not working on some v.redd.it videos HOT 1
- redditp doesnt work when i put in a subreddit however it works when i put in a user HOT 5
- Support images from Redgifs HOT 1
- No sounds on gifs HOT 1
- Seems to pick lowest quality for v.reddit.it videos
- Redgifs Sound Not Enabled By Sound Checkbox [SOLUTION IMMINENT] HOT 3
- Redditp seems to be entirely broken for me HOT 7
- Please fix (or improve the handling of) the "Redditp booboo TypeError" bug HOT 4
- Can't view multiple subreddits on mobile HOT 3
- g
- failed ajax
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from redditp.