Giter Club home page Giter Club logo

Comments (4)

SmallJoker avatar SmallJoker commented on August 28, 2024

https://github.com/Uberi/Minetest-WorldEdit/blob/master/worldedit_commands/safe.lua#L39
line must be called

func = function(name, param)

same with L61

from minetest-worldedit.

khonkhortisan avatar khonkhortisan commented on August 28, 2024

//y and //n do not use (name, param) from the chatcommand. Instead, they get whatever was saved by safe_region.
It is assumed that someone gets the safe_region message before running //y, which is why it crashes when there's nothing in safe_region_name.
Also, it is assumed that there will only be one person with confirmation waiting:
personA sets a large region, then runs //fixlight, getting the prompt.
personB sets a similar large region, then runs //fixlight, also getting the prompt. personA's to-do list is cleared.
personB runs //y, actually doing .fixlight, and clearing the to-do list again.
personA runs //y on an empty to-do list, getting a crash.
First, it must do nothing if safe_region_callback, safe_region_name, and safe_region_param have been emptied or never filled.
Second, they must be turned into tables with player name as the key, so that two players using safe_region and //y or //n don't interfere with each other.

from minetest-worldedit.

Uberi avatar Uberi commented on August 28, 2024

Oops, my bad, I'll get on that ASAP.

from minetest-worldedit.

Uberi avatar Uberi commented on August 28, 2024

Fixed in 4660927! Thanks for the report ChaosWormz and thanks for the explanation khonkhortisan.

from minetest-worldedit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.