Comments (4)
Hey @t-tte, I've started working on the mentioned comparison using our JustCause framework and wanted to highlight a few ideas/notes/problems.
-
I've started using
rpy2
in order to use the original rlearner implementation directly from Python. However, as I am not familiar with the method in detail, it is hard to know, how to use the RLearner from causalml in order to get the closest possible imitation. (As the goal for me would be to show how the R implementation fares against the Python implementation) -
I've reimplemented the benchmarking data (A to D) from Nie and Wager inside the JustCause framework to allow easy usage.
First results are a little confusing as in one case (boost) the R implementation is significantly better while in the other (lasso) the Python Version is much better. So much even, that there seems to be some mistake.. (using only 100 replications of the IHDP dataset, the simulation data from Nie and Wager will follow):
I'll publish the notebook soon and let you know about the progress I'll make on this. However, I'll limit myself to 1 or 2 benchmark datasets.
from causalml.
Thanks for the note! Great to hear you've started working on this, and that you've implemented some of the simulations in JustCause. I'll have a closer look and will keep you updated.
As to the differences between the methods, that's indeed a tricky one. My first two hypotheses would be:
- The base-learners or some of their parameters are set differently
- The propensity score is calculated differently
If you share your notebook, I'll be very happy to dig deeper to see where the root cause of the differences might be.
from causalml.
Hey again,
The notebook is on a separate branch here, since we're still changing stuff within the JustCause API. I haven't looked at it in detail yet, but will return to it once we've finished our fully documented version.
from causalml.
This issue was partly addressed in PR #443. As I have no immediate plans to work on the remaining simulations, I'm closing the issue.
from causalml.
Related Issues (20)
- Columns and DataType Not Explicitly Set on line 154 of test_sensitivity.py
- Testing get_cumgain produces errors HOT 1
- `pytest -vs \tests\ -cov \causalml\` fails on windows HOT 1
- causalml/match.py::main imports nonexistent vars from features.py
- SHAP Tree_Explainer failed in notebook HOT 7
- add clean conda env install sequence to docs/installation.rst
- Validating model via predictions HOT 2
- build fails in test_causal_trees.py, no attribute _support_missing_values HOT 2
- SHAP Explainer error
- Expose leaf sizes for `honestApproach` trees (or update `nodeSummary`s)
- maq git repo dependency blocks pypi publish HOT 3
- Installation error on Databrick Cluster HOT 2
- when the example jupyter notebook run, it raises an error HOT 1
- Update requirements HOT 2
- How to analyze the causal effect with real world excel data HOT 1
- Issues with Serializing UpliftTreeClassifier using pickle in Python HOT 1
- create_table_one to have an argument ignoring std in output
- Stratified sampling never works for `honesty=True`
- return_ci=True is not properly passed in get_ate_ci of the Sensitivity class in sensitivity.py
- OneHotEncoder UnboundLocalError HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from causalml.