Giter Club home page Giter Club logo

Comments (4)

MaximilianFranz avatar MaximilianFranz commented on May 10, 2024 3

Hey @t-tte, I've started working on the mentioned comparison using our JustCause framework and wanted to highlight a few ideas/notes/problems.

  1. I've started using rpy2 in order to use the original rlearner implementation directly from Python. However, as I am not familiar with the method in detail, it is hard to know, how to use the RLearner from causalml in order to get the closest possible imitation. (As the goal for me would be to show how the R implementation fares against the Python implementation)

  2. I've reimplemented the benchmarking data (A to D) from Nie and Wager inside the JustCause framework to allow easy usage.

First results are a little confusing as in one case (boost) the R implementation is significantly better while in the other (lasso) the Python Version is much better. So much even, that there seems to be some mistake.. (using only 100 replications of the IHDP dataset, the simulation data from Nie and Wager will follow):

Rlearner with XGBoost

Rlearner with GLMNET

I'll publish the notebook soon and let you know about the progress I'll make on this. However, I'll limit myself to 1 or 2 benchmark datasets.

from causalml.

t-tte avatar t-tte commented on May 10, 2024

Hi @MaximilianFranz

Thanks for the note! Great to hear you've started working on this, and that you've implemented some of the simulations in JustCause. I'll have a closer look and will keep you updated.

As to the differences between the methods, that's indeed a tricky one. My first two hypotheses would be:

  • The base-learners or some of their parameters are set differently
  • The propensity score is calculated differently

If you share your notebook, I'll be very happy to dig deeper to see where the root cause of the differences might be.

from causalml.

MaximilianFranz avatar MaximilianFranz commented on May 10, 2024

Hey again,

The notebook is on a separate branch here, since we're still changing stuff within the JustCause API. I haven't looked at it in detail yet, but will return to it once we've finished our fully documented version.

from causalml.

t-tte avatar t-tte commented on May 10, 2024

This issue was partly addressed in PR #443. As I have no immediate plans to work on the remaining simulations, I'm closing the issue.

from causalml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.