incorporate static time shifts into the values displayed in the waveform fits plots about mtuq HOT 3 CLOSED

Agreed, the proposed change would be a helpful improvement. Also, the above description matches my understanding of the current mtuq implementation.

The reason for the current implementation I think is that user-supplied static time shifts get applied to the Green's functions during data processing and become less accessible thereafter.

Applying the static time shifts during data processing has an advantage in that the static time shifts get applied once and for all, and the data and synthetic windows are well centered prior to cut-and-paste misfit function evaluation. A side effect, however, is that the user-supplied static time shifts are not immediately accessible to the misfit function, which writes out all the attributes used for plotting.

My first thought is that it should easily doable to include these static time shifts by default in the waveform annotations. Also, we would want them to be written out in some way in the json files used for time shift spider plots. Adding this the high priority list...

from mtuq.

Addressed in new pull request #248

For more information see here

https://github.com/rmodrak/mtuq/blob/master/tests/test_time_shifts.py

In particular

    #
    # MTUQ distinguishes between the following different types of 
    # time-shift corrections
    # 
    # - "static_shift" is an initial user-supplied time shift applied during
    #   data processing
    #
    # - "time_shift" is a subsequent cross-correlation time shift applied during 
    #   misfit evaluation
    #
    # - "total_shift" is the total correction, or in other words the sum of
    #   static and cross-correlation time shifts
    #

from mtuq.

Please feel free to reopen if necessary

from mtuq.