Giter Club home page Giter Club logo

Comments (10)

tzookb avatar tzookb commented on August 12, 2024

yes it is surely needed!
Ill find some time soon and start working on it

from tbmsg.

tzookb avatar tzookb commented on August 12, 2024

@abhishek238 please open a new issue, so we could discuss there.

from tbmsg.

Raou1d avatar Raou1d commented on August 12, 2024

This is something i ran into my self! I have been looking into it. Shouldn't be that hard to make but depends on how far you want to take it. Making a function like this should get people started:

public static function getMessages($convId, $start = 0, $perPage = 20) {
   // SQL QUERY LIMIT = $perPage and OFFSET = $start.
}

This way you won't need to load all messages from the DB and should work great for ajax calls but the only problem with this is that you won't know how many pages there are in total. This also means you won't be able to make a Laravel Paginator object. I don't like working with the Paginator for messages and don't recommend it. But if that is what you want you could make something like:

$conv = TBMsg::getConversationMessages($convId, $userId,);
$conv->getAllMessages();
$conv->paginateMessages($perPage);

-----------------------

public function paginateMessages($perPage = 20) {
  // $messages= all the messages
  // $total = count() on all the $messages
  // Paginator::make($collection->all(), $total, $perPage);
}

The problem here is that Pagenator::make() will use Paginator::getCurrentPage() to get the current page from the GET parameters. This will also make the package more dependent on laravel.

Raoul

from tbmsg.

tzookb avatar tzookb commented on August 12, 2024

yes your first option will be the option, as I dont want to add the laravel paginator now.

Ill implement it soon

from tbmsg.

tzookb avatar tzookb commented on August 12, 2024

just finished the big change with tests, so now it will be much safer to change stuff.
I'll try to add it soon

from tbmsg.

tmunzar-jfish avatar tmunzar-jfish commented on August 12, 2024

Yes, this feature is very much required to move forward.
I'd love to help out implementing this if you don't have the time.

from tbmsg.

tzookb avatar tzookb commented on August 12, 2024

Hi @tmunzar-jfish I would always would be happy to get help :)

from tbmsg.

rohitnaidu19 avatar rohitnaidu19 commented on August 12, 2024

Is this feature implemented yet?

from tbmsg.

tzookb avatar tzookb commented on August 12, 2024

not yet, hope to do it soon, or would be happy if you have suggestions.

from tbmsg.

rohitnaidu19 avatar rohitnaidu19 commented on August 12, 2024

Your package is awesome. One of the best chat systems for laravel
available. Very flexible. Just a few issues else it's perfect.

Wish I could help but I'm a noob :-)
On Dec 21, 2015 4:47 PM, "Tzook" [email protected] wrote:

not yet, hope to do it soon, or would be happy if you have suggestions.


Reply to this email directly or view it on GitHub
#22 (comment).

from tbmsg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.