Giter Club home page Giter Club logo

Comments (6)

Tzahi12345 avatar Tzahi12345 commented on July 24, 2024 1

Awesome, thanks for the confirmation! I'll get those changes done for the next update, hopefully no more thumbnail issues after that lol

from youtubedl-material.

Tzahi12345 avatar Tzahi12345 commented on July 24, 2024

I've had a similar error complaining about no AtomicParsley before, and I believe it's related to the --embed-thumbnail argument.

If you're on Windows, you can get Atomic Parsley here. If you're running on a Debian-based Linux distro like Ubuntu, then this command should suffice:

sudo apt-get install atomicparsley

I believe download it does fix the issue, let me know if it does! If so, I'll just update the README to note that thumbnail args require AtomicParsley installed.

EDIT: If you're on Docker, it'll be a bit more complicated to fix, so lmk if this is the case

from youtubedl-material.

Roxedus avatar Roxedus commented on July 24, 2024

It should be added to the container regardless

from youtubedl-material.

Tzahi12345 avatar Tzahi12345 commented on July 24, 2024

It should be added to the container regardless

True! I just wanted confirmation it would solve the issue, no point in adding a dependency unnecessarily :)

I was planning on testing & adding this for the next update (at least on Docker), but it might be a couple weeks until that happens. In the meantime, I'll keep this issue open until I do a couple things:

  1. Verify AtomicParsley is needed/works for thumbnails and add it as an optional dependency in the README
  2. Add it as a dependency to the Dockerfile

from youtubedl-material.

Roxedus avatar Roxedus commented on July 24, 2024

Well, it is related to the --embed-thumbnail argument, I added it to my own YTDL container to be able to use that argument.

https://github.com/Roxedus/Arkiverer/blob/master/amd64.Dockerfile#L15

from youtubedl-material.

Tzahi12345 avatar Tzahi12345 commented on July 24, 2024

Quick update!

README is updated and so is the Dockerfile. Thanks @vveerar1 for bringing up the issue, and thanks @Roxedus for the implementation, it was super helpful.

Alright, closing the issue, the nightly builds should have AtomicParsley included and the next update will have it as well. Thanks again guys

from youtubedl-material.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.