Comments (9)
Tzahi12345
commented on July 24, 2024
1
@radim-ek thanks for the additional logs!
Regarding the particular bug you're facing, it has been fixed and will roll out later this week (3.5.1) under the same container version (3.5).
I'll let you know once I push these fixes, there are a couple other things I want to work out before finalizing the update, but regardless it'll be out soon. It's a nasty bug so I want to get rid of it ASAP as well haha
from youtubedl-material.
Tzahi12345
commented on July 24, 2024
1
Wanted to update this issue and let you guys know that the bug fix has been included in the most recent update (3.5.1)! Basically, when youtube-dl fails to update, an info message is shown and the server continues on without erroring/crashing.
Check it out here. I'm going to go ahead and close this issue. @gerroon there is still the outstanding bug where app/app.js is unable to be found on some Docker installs. I'll keep you updated on that bug on this issue instead to avoid duplicates.
I'll also be modifying the update process for youtube-dl in the next update (3.6) so it fails less frequently. Feel free to open a new issue if you face any other problems. Thanks for notifying me of the bug, I really appreciate it :)
from youtubedl-material.
gerroon
commented on July 24, 2024
OK it seems like the whole docker setup changed. So I tried the new version, still no luck.
Removing intermediate container 11d9e864ec85
---> b6d9adc9aa7d
Successfully built b6d9adc9aa7d
Successfully tagged tzahi12345/youtubedl-material:3.5
WARNING: Image for service ytdl_material was built because it did not already exist. To rebuild this image you must use `docker-compose build` or `docker-compose up --build`.
Recreating youtubedl-material_ytdl_material_1 ... done
Attaching to youtubedl-material_ytdl_material_1
ytdl_material_1 | internal/modules/cjs/loader.js:796
ytdl_material_1 | throw err;
ytdl_material_1 | ^
ytdl_material_1 |
ytdl_material_1 | Error: Cannot find module '/app/app.js'
ytdl_material_1 | at Function.Module._resolveFilename (internal/modules/cjs/loader.js:793:17)
ytdl_material_1 | at Function.Module._load (internal/modules/cjs/loader.js:686:27)
ytdl_material_1 | at Function.Module.runMain (internal/modules/cjs/loader.js:1043:10)
ytdl_material_1 | at internal/main/run_main_module.js:17:11 {
ytdl_material_1 | code: 'MODULE_NOT_FOUND',
ytdl_material_1 | requireStack: []
ytdl_material_1 | }
youtubedl-material_ytdl_material_1 exited with code 1
ytdl_material_1 | internal/modules/cjs/loader.js:796
ytdl_material_1 | throw err;
ytdl_material_1 | ^
ytdl_material_1 |
ytdl_material_1 | Error: Cannot find module '/app/app.js'
ytdl_material_1 | at Function.Module._resolveFilename (internal/modules/cjs/loader.js:793:17)
ytdl_material_1 | at Function.Module._load (internal/modules/cjs/loader.js:686:27)
ytdl_material_1 | at Function.Module.runMain (internal/modules/cjs/loader.js:1043:10)
ytdl_material_1 | at internal/main/run_main_module.js:17:11 {
ytdl_material_1 | code: 'MODULE_NOT_FOUND',
ytdl_material_1 | requireStack: []
ytdl_material_1 | }
ytdl_material_1 | internal/modules/cjs/loader.js:796
ytdl_material_1 | throw err;
ytdl_material_1 | ^
......
docker-compose up
Starting youtubedl-material_ytdl_material_1 ... done
Attaching to youtubedl-material_ytdl_material_1
ytdl_material_1 | internal/modules/cjs/loader.js:796
ytdl_material_1 | throw err;
ytdl_material_1 | ^
ytdl_material_1 |
ytdl_material_1 | Error: Cannot find module '/app/app.js'
ytdl_material_1 | at Function.Module._resolveFilename (internal/modules/cjs/loader.js:793:17)
ytdl_material_1 | at Function.Module._load (internal/modules/cjs/loader.js:686:27)
ytdl_material_1 | at Function.Module.runMain (internal/modules/cjs/loader.js:1043:10)
ytdl_material_1 | at internal/main/run_main_module.js:17:11 {
ytdl_material_1 | code: 'MODULE_NOT_FOUND',
ytdl_material_1 | requireStack: []
ytdl_material_1 | }
youtubedl-material_ytdl_material_1 exited with code 1
ytdl_material_1 | internal/modules/cjs/loader.js:796
ytdl_material_1 | throw err;
ytdl_material_1 | ^
ytdl_material_1 |
ytdl_material_1 | Error: Cannot find module '/app/app.js'
ytdl_material_1 | at Function.Module._resolveFilename (internal/modules/cjs/loader.js:793:17)
ytdl_material_1 | at Function.Module._load (internal/modules/cjs/loader.js:686:27)
ytdl_material_1 | at Function.Module.runMain (internal/modules/cjs/loader.js:1043:10)
ytdl_material_1 | at internal/main/run_main_module.js:17:11 {
ytdl_material_1 | code: 'MODULE_NOT_FOUND',
ytdl_material_1 | requireStack: []
ytdl_material_1 | }
ytdl_material_1 | internal/modules/cjs/loader.js:796
ytdl_material_1 | throw err;
ytdl_material_1 | ^
from youtubedl-material.
Tzahi12345
commented on July 24, 2024
INFO: Found new update for youtube-dl. Updating binary...
This first error seems to have occurred during a failure to update the youtube-dl binaries. I changed the code around so it won't crash when it errors during updating, but I'm not sure why it errored in the first place. I'll release a minor version update sometime this week with that fix included.
Error: Cannot find module '/app/app.js'
This next error is a hint as to what might be wrong. Basically, it might be your image that is messed up - another user actually had the same problem.
Just to see if that's the case, see if you can build your own image to fix this problem:
Here's a zip that will make it really easy to create your own build.
Just extract the zip and run docker-compose build in the resulting directory. Your 3.5 image should be rebuilt and app.js will be in the right location (hopefully). Let me know if this helps at all!
from youtubedl-material.
gerroon
commented on July 24, 2024
Hi
Thanks for the update. This version works for me.
Is it possible that the actual docker image is missing that app.js?
from youtubedl-material.
Tzahi12345
commented on July 24, 2024
Thanks for the update. This version works for me.
Great to hear :)
Is it possible that the actual docker image is missing that app.js?
I hope not! When I pull the official 3.5 image it works without issue for me, so I wonder what's going on. It seems more widespread than just a rare incident, since another issue has already been made about it. Hmm.
from youtubedl-material.
radim-ek
commented on July 24, 2024
| date | stream | content |
|---|---|---|
| 2020-03-26 15:23:50 | stdout | �[90m at processTimers (internal/timers.js:475:7)�[39m |
| 2020-03-26 15:23:50 | stdout | �[90m at listOnTimeout (internal/timers.js:531:17)�[39m |
| 2020-03-26 15:23:50 | stdout | at Timeout._onTimeout (/app/app.js:676:21) |
| 2020-03-26 15:23:50 | stdout | TypeError: Cannot read property 'close' of undefined |
| 2020-03-26 15:23:50 | stdout | |
| 2020-03-26 15:23:50 | stdout | ^ |
| 2020-03-26 15:23:50 | stdout | watcher.close(); |
| 2020-03-26 15:23:50 | stdout | /app/app.js:676 |
| 2020-03-26 15:23:40 | stdout | (node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. |
| 2020-03-26 15:23:40 | stdout | (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2) |
| 2020-03-26 15:23:40 | stdout | at processTicksAndRejections (internal/process/task_queues.js:94:5) |
| 2020-03-26 15:23:40 | stdout | at /app/app.js:656:23 |
| 2020-03-26 15:23:40 | stdout | at checkExistsWithTimeout (/app/app.js:673:12) |
| 2020-03-26 15:23:40 | stdout | at new Promise () |
| 2020-03-26 15:23:40 | stdout | at /app/app.js:680:12 |
| 2020-03-26 15:23:40 | stdout | at Object.access (fs.js:177:10) |
| 2020-03-26 15:23:40 | stdout | (node:1) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be one of type string, Buffer, or URL. Received type object |
| 2020-03-26 15:23:40 | stdout | INFO: Found new update for youtube-dl. Updating binary... |
| 2020-03-26 15:23:39 | stdout | HTTP: Started on PORT 17442 |
| 2020-03-26 15:23:01 | stdout | �[90m at processTimers (internal/timers.js:475:7)�[39m |
| 2020-03-26 15:23:01 | stdout | �[90m at listOnTimeout (internal/timers.js:531:17)�[39m |
| 2020-03-26 15:23:01 | stdout | at Timeout._onTimeout (/app/app.js:676:21) |
| 2020-03-26 15:23:01 | stdout | TypeError: Cannot read property 'close' of undefined |
| 2020-03-26 15:23:01 | stdout | |
| 2020-03-26 15:23:01 | stdout | ^ |
| 2020-03-26 15:23:01 | stdout | watcher.close(); |
| 2020-03-26 15:23:01 | stdout | /app/app.js:676 |
| 2020-03-26 15:22:51 | stdout | (node:1) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. |
| 2020-03-26 15:22:51 | stdout | (node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2) |
| 2020-03-26 15:22:51 | stdout | at processTicksAndRejections (internal/process/task_queues.js:94:5) |
| 2020-03-26 15:22:51 | stdout | at /app/app.js:656:23 |
| 2020-03-26 15:22:51 | stdout | at checkExistsWithTimeout (/app/app.js:673:12) |
| 2020-03-26 15:22:51 | stdout | at new Promise () |
| 2020-03-26 15:22:51 | stdout | at /app/app.js:680:12 |
| 2020-03-26 15:22:51 | stdout | at Object.access (fs.js:177:10) |
| 2020-03-26 15:22:51 | stdout | (node:1) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be one of type string, Buffer, or URL. Received type object |
| 2020-03-26 15:22:51 | stdout | INFO: Found new update for youtube-dl. Updating binary... |
| 2020-03-26 15:22:51 | stdout | HTTP: Started on PORT 17442 |
Mayby this help? Downloaded today from https://registry.hub.docker.com/r/tzahi12345/youtubedl-material
from youtubedl-material.
radim-ek
commented on July 24, 2024
"Failed to get youtube-dl binary path at location: node_modules/youtube-dl/bin/details. Cancelling update check. | stdout"
But worked and lauched. No I am on WEB GUI.
from youtubedl-material.
Tzahi12345
commented on July 24, 2024
"Failed to get youtube-dl binary path at location: node_modules/youtube-dl/bin/details. Cancelling update check. | stdout"
But worked and lauched. No I am on WEB GUI.
Good catch! This is actually intentional. The bug fix in this patch is to prevent crashing/crazy errors that might come about from a failed download. In the next update I will include additional measures to update youtube-dl if it fails the normal way.
from youtubedl-material.
Related Issues (20)
- [FEATURE] Is it possible to override the download path for subscription
- [BUG] Container will not be able to run properly non-privileged HOT 1
- [FEATURE] Set default max quality in config
- How to reset Users account ?
- [BUG] Content does not refresh when switching between subs using side menu
- [BUG] Scheduling a task hangs application, won't start fully HOT 1
- [FEATURE] Make mounted folders paths configurable using environment variable
- [BUG]
- [BUG] Searching goes on forever HOT 2
- YoutubeDl material doesnt download a subscription. HOT 3
- [BUG] pm2 not declared as dependency
- [BUG] Skipping player responses from android clients HOT 1
- [BUG] Can't add subscriptions. It just loads forever and never adds the channel.
- [BUG] container won't start HOT 8
- [BUG] Video file name too long error
- [BUG] Thumbnails don't load if their path contains a "%" character HOT 1
- I'm looking for the best way to set the codecs for downloads
- [BUG] Cant delete individual notifications
- [BUG] Should install mutagen when program installed (esp. for Docker)
- [FEATURE] Explain execa, delimiters, argument usage better & include some helpful messages when people enter custom args
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from youtubedl-material.