Comments (5)
Was able to implement new buttons for the settings dialog, let me know if this does the job in terms of eliminating confusion:
https://gfycat.com/cavernousenormousirishdraughthorse
Also, you can see the new dark mode there :) not 100% convinced on the lighter blue top toolbar so I'll ask around more to get a better consensus.
from youtubedl-material.
For the dark mode I think we can still use the same hue of blue for the top bar. The dark blue seems a bit too toned down and I much prefer the vividness of the lighter blue. It's more friendly.
I asked around and the consensus agrees with you. I did think the background was too dark, but they also seemed to prefer the default toolbar color better for the dark mode.
The about dialog's close button should probably just be an X in the top right. In any case, buttons like the close button be it an X button Windows-window-style like I imagine or the way you implemented it should have much more contrast against the background.
True, the close button doesn't really stand out. It should be more obvious what the user should do, and the information presented in general should be easier on the eyes, rather than a blob of text with some emphasis.
We have a Save button, a cancel button... But no close button. Cancelling after saving is very unintuitive and confusing UX
Hm, what if it said "Close" when no settings were changed, and "Cancel" when something has been updated but not saved? I think this would make more sense.
Technology be blessed though, hard to imagine how I'd get through this without the amazing things technology lets us achieve from the comfort of our homes. :D
Couldn't agree more, thank god for the internet and modern computers, otherwise this would be unbearable. So glad all this exists <3. Besides, there are a few silver linings, like I get to work on this project more.
from youtubedl-material.
Looks good so far! Personally have never seen cancel/close combined buttons before and I think it may be against a lot of HIGs out there, but this is miles better already so I'll take it :D
If the blue is too light for you, feel free to shift it a little more into the darker realm, but be careful about it. That being said I think keeping the color palette simple for accent and "branding"-colors is always advisable. The darker blue just is way too unsaturated and dim. If anything it could look better on the bright theme, but even then...
This might also be a vastly different experience from monitor to monitor. Personally I'm using a Surface Pro 6, a Sony Bravia TV (XE90) as well as a Note 9 and on those the dark blue looks like uncoordinated color choice. :P
Asking around definitely is a good idea! Maybe the application name could use a shadow backdrop as well, a subtle one, to make it stand out more and a bit more "logo-ey". Right now it looks more like a description than a branding. Maybe incorporate the application's logo into the bar as well? Only seeing the icon on my unRAID dashboard and generally as favicon is a bit weird I think? Definitely do make it appear in the About window as well though!
from youtubedl-material.
Personally have never seen cancel/close combined buttons before and I think it may be against a lot of HIGs out there, but this is miles better already so I'll take it :D
You can see Google's take on dialog actions for Material Design here. I'm neutral on the matter, but what's pushing me to continue using the official system is that the Angular Material Design library makes it too easy as the dialogs provide built-in functionality to add actions.
The truth is, I'm not even using dialog's for the right reasons all the time, at least according to Google. They're supposed to "provide critical information or ask for a decision" and "should be used sparingly" (source). Thankfully, I'm not the only one taking liberties when implementing Material Design, I just noticed FreeNAS actually does the same thing 🤷♂️
Maybe incorporate the application's logo into the bar as well? Only seeing the icon on my unRAID dashboard and generally as favicon is a bit weird I think? Definitely do make it appear in the About window as well though!
I like this idea. I'm not sure where to put the logo on the home page, but I was able to find a spot for it on the about page.
Regarding the top toolbar, you do have a good point that I'm lacking on branding. I changed the default title to YoutubeDL-Material, made the toolbar itself sticky (so when you scroll down it stays at the top), added a drop shadow to the toolbar to give it more prominence, and lastly I added a super subtle drop shadow on the top title.
Here's a couple screenshots so you know what I mean:
It's minor, but I hope it makes the home & about pages feel less bland.
Also included in the second image is update checking functionality (so users can see if an update is available).
from youtubedl-material.
Visual changes have been implemented in the new update (3.5.1) along with a lot of bug fixes. Check it out, and don't hesitate to open up any other issues regarding the UI or anything else.
Thanks for the help in truly making the dark mode "dark"!
from youtubedl-material.
Related Issues (20)
- [FEATURE] Is it possible to override the download path for subscription
- [BUG] Container will not be able to run properly non-privileged HOT 1
- [FEATURE] Set default max quality in config
- How to reset Users account ?
- [BUG] Content does not refresh when switching between subs using side menu
- [BUG] Scheduling a task hangs application, won't start fully HOT 1
- [FEATURE] Make mounted folders paths configurable using environment variable
- [BUG]
- [BUG] Searching goes on forever HOT 2
- YoutubeDl material doesnt download a subscription. HOT 3
- [BUG] pm2 not declared as dependency
- [BUG] Skipping player responses from android clients HOT 1
- [BUG] Can't add subscriptions. It just loads forever and never adds the channel.
- [BUG] container won't start HOT 8
- [BUG] Video file name too long error
- [BUG] Thumbnails don't load if their path contains a "%" character HOT 1
- I'm looking for the best way to set the codecs for downloads
- [BUG] Cant delete individual notifications
- [BUG] Should install mutagen when program installed (esp. for Docker)
- [FEATURE] Explain execa, delimiters, argument usage better & include some helpful messages when people enter custom args
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from youtubedl-material.