Positional arguments listed out-of-order when inheriting from base command class about clifx HOT 2 CLOSED

From a quick inspection, it looks like the issue is with this bit of code, which determines the list of parameters that a CommandSchema is constructed with:

This list of parameters is enumerated in that order by HelpConsoleFormatter:

If I print out the properties of each type of command in the minimal repro code, I get the properties back in different orders:

public static async Task<int> Main()
{
    var doesNotInheritFromBaseCommandProperties = typeof(DoesNotInheritFromBaseCommand).GetProperties();
    var inheritFromBaseCommandProperties = typeof(InheritFromBaseCommand).GetProperties();
    return 1;
}

doesNotInheritFromBaseCommandProperties
{System.Reflection.PropertyInfo[2]}
    [0]: {Int64 Foo}
    [1]: {Int64 Bar}
inheritFromBaseCommandProperties
{System.Reflection.PropertyInfo[2]}
    [0]: {Int64 Bar}
    [1]: {Int64 Foo}

Since ParameterSchema has the Order property associated with it, it might be possible to order the list of parameters by this property before passing it to the CommandSchema constructor e.g.

var parameterSchemas = type.GetProperties() 
    .Select(ParameterSchema.TryResolve) 
    .Where(p => p is not null)
    .OrderBy(p => p.Order)
    .ToArray(); 

from clifx.

Hi, thanks for the report. Yes, the parameters need to be sorted by order in the help text renderer, it's a mistake that they aren't. PRs are welcome.

from clifx.