Comments (5)
I think Ghostery handles this reasonably well with their weekly updated tracker lists with an "Auto Update" option. https://www.ghostery.com/en/help/firefox
from ad-detector.
Is this necessary for Chrome version? https://developer.chrome.com/extensions/autoupdate
from ad-detector.
@dsernst, as much as people “may not like the idea of a server updating their rules” those same people are very likely to be wary of autoupdates too. Especially with a whole market for buying extensions and injecting them with ads/malware.
The biggest security problem with AdDetector’s rules the way they are now is that you will be importing JavaScript code that needs to be executed. This is why a system like Ghostery’s or Disconnect’s cannot be compared. They pass a list of text that needs to be parsed by the add-on. If someone sends you a fake update all they could do is unblock ads or block non-ads and confuse you. If someone sends AdDetector a fake rules.js
they get to execute JavaScript code through the extension and can do anything the browser allows them (injecting ads, scraping your email, …).
Could the rules be converted to something like XPath queries? Unlike CSS selectors these would allow to match text contents as necessary for things like BuzzFeed’s match
function and most of the getSponsor
functions.
from ad-detector.
Haven't looked at the code/rules much, but I've done something along the lines of what Zegnat suggested. We'd have a bunch of selector methods in the source, and configure a list of method names with arguments for each website. This wasn't public or in javascript, so I can't speak to security implications.
from ad-detector.
I'm actually really interested in using such a list of rules for another (non-javascript) project. Is there any appetite for converting the rules to a purely data form (like Zegnat suggested)?
Looking through the current rules, the match functions mostly look easy enough to convert...
This buys you auto-updating without downloading javascript, and it also makes the rules available to a larger community...
from ad-detector.
Related Issues (20)
- Add a 'Report sponsored content to AdDetector' item in the context menu. HOT 1
- False positive (I think) HOT 2
- Create rules for each of these articles.
- 0.1.12 is flagging all pages at theatlantic.com HOT 2
- Throws the red flag on Gawker.com homepage HOT 1
- Broken rule on forbes.com HOT 2
- Gawker.com flagged as sponsored HOT 2
- The Daily Beast HOT 1
- Incorrectly reports some sponsors HOT 1
- The Bold Italic HOT 2
- Qz issue HOT 1
- Wired.com sponsored stories HOT 2
- rtlz.nl support HOT 1
- [request] NRC Q HOT 2
- TheNextWeb support HOT 3
- Chrome version outdated? HOT 1
- [request] Several Dutch sites HOT 3
- [request] Motherboard/VICE HOT 2
- Firefox: e10s support HOT 1
- web extension
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ad-detector.