Giter Club home page Giter Club logo

Comments (5)

dtran320 avatar dtran320 commented on May 24, 2024

I think Ghostery handles this reasonably well with their weekly updated tracker lists with an "Auto Update" option. https://www.ghostery.com/en/help/firefox

from ad-detector.

dsernst avatar dsernst commented on May 24, 2024

Is this necessary for Chrome version? https://developer.chrome.com/extensions/autoupdate

from ad-detector.

Zegnat avatar Zegnat commented on May 24, 2024

@dsernst, as much as people “may not like the idea of a server updating their rules” those same people are very likely to be wary of autoupdates too. Especially with a whole market for buying extensions and injecting them with ads/malware.

The biggest security problem with AdDetector’s rules the way they are now is that you will be importing JavaScript code that needs to be executed. This is why a system like Ghostery’s or Disconnect’s cannot be compared. They pass a list of text that needs to be parsed by the add-on. If someone sends you a fake update all they could do is unblock ads or block non-ads and confuse you. If someone sends AdDetector a fake rules.js they get to execute JavaScript code through the extension and can do anything the browser allows them (injecting ads, scraping your email, …).

Could the rules be converted to something like XPath queries? Unlike CSS selectors these would allow to match text contents as necessary for things like BuzzFeed’s match function and most of the getSponsor functions.

from ad-detector.

ashrestha91 avatar ashrestha91 commented on May 24, 2024

Haven't looked at the code/rules much, but I've done something along the lines of what Zegnat suggested. We'd have a bunch of selector methods in the source, and configure a list of method names with arguments for each website. This wasn't public or in javascript, so I can't speak to security implications.

from ad-detector.

bcampbell avatar bcampbell commented on May 24, 2024

I'm actually really interested in using such a list of rules for another (non-javascript) project. Is there any appetite for converting the rules to a purely data form (like Zegnat suggested)?
Looking through the current rules, the match functions mostly look easy enough to convert...
This buys you auto-updating without downloading javascript, and it also makes the rules available to a larger community...

from ad-detector.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.