locallangXMLOverride don't work correctly in Templates about ext-solr HOT 10 CLOSED

What TYPO3 version, what extension version are you using?

from ext-solr.

bump @FlorianEngelke, any feedback?

from ext-solr.

closing for no feedback, feel free to re-open once you can provide needed feedabck

from ext-solr.

I can confirm this issue. I'm using solr 3.0.1. I have added this line to my AdditionalConfiguration.php of TYPO3 6.2:

$GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride']['EXT:solr/Resources/Private/Language/PluginResults.xml'][] = 'fileadmin/default/extensions/solr/Resources/Private/Language/PluginResults.xml';

The PluginResults.xml is just a copy of the origin file. I can change the value of key "results_range" but changing the submit-button label does not work f.e.

from ext-solr.

It works for me with TYPO3 6.2:

I have added to AdditionalConfiguration.php:

$GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride']['de']['EXT:solr/Resources/Private/Language/PluginResults.xml'][] = 'EXT:my_extension/Resources/Private/Language/PluginResults.xml';

And the translations will be overridden.

from ext-solr.

Can this change please be reverted? It is not needed IMO and it breaks merging of exising language files and override labels. Currently you need to copy all labels in the override file which is quite unhandy.

I think the problem lies in the configuration. The EXT: prefix is already resolved in the LLL view helper. This is why you need to use the absolute filename in your override config:

$GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride']['de']['/var/www/mywebroot/typo3conf/ext/solr/Resources/Private/Language/PluginResults.xml'][] = 'EXT:my_extension/Resources/Private/Language/PluginResults.xml';

Overriding works perfectly (at least in TYPO3 6.2) when I use the absolute path in my config and remove the overrideLocalLangFile() code from the LLL view helper.

from ext-solr.

According to the docs the key is not an absolute path, but uses the EXT: notation: https://docs.typo3.org/typo3cms/CoreApiReference/Internationalization/Translation/Index.html#xliff-translating-custom

from ext-solr.

re-opening for discussion

from ext-solr.

The problem ist how GeneralUtility::readLLfile() is called in the Lll view helper.

The view helper is registered in PluginBase::initializeTemplateEngine():

$template->addViewHelperIncludePath($this->extKey, 'Classes/ViewHelper/');
$template->addViewHelper('LLL', array(
    'languageFile' => $GLOBALS['PATH_solr'] .'Resources/Private/Language/' . str_replace('Pi', 'Plugin', $this->getPluginKey()) . '.xml',
    'llKey'        => $this->LLkey
));

The variable $GLOBALS['PATH_solr'] already contains the resolved Extension path and not EXT:solr/....

This is why the override mechanism will only work when you use the absolute filename.

from ext-solr.

ah ok, then let's fix the root, not the symptom!

from ext-solr.