refactor resizing api. about d3kit HOT 3 CLOSED

i propose to refactor the current resizing api from:

skeleton.resizeToFitContainer: resize to fit the skeleton's container.
skeleton.resizeToAspectRatio: resize to specified aspect ratio.

to:

skeleton.resize - immediately resize chart following rules as specified by autoResize() and autoResizeToAspectRatio().

this does limit functionality a little, bit, but i think it fits better with common use cases and is less confusing to new users.

from d3kit.

I like the simplification, but specifying options via autoResize maybe less intuitive when I want to resize only once. How about grouping resize options together, which can be set via either resize(resizeOptions) or autoResize(resizeOptions)?

Then, call resize() if you want to resize once, autoResize() for auto-detect.

In resizeOptions

• auto:Boolean
• side: 'width', 'height' or 'both'
• aspectRatio: null or some value

With this we can also implement autoResize by calling resize and set auto to true.

On second thought, what about renaming both to fit() and autoFit() rather than resize()?

from d3kit.

Resolved in v3

from d3kit.