Comments (3)
i propose to refactor the current resizing api from:
skeleton.resizeToFitContainer: resize to fit the skeleton's container.
skeleton.resizeToAspectRatio: resize to specified aspect ratio.
to:
skeleton.resize - immediately resize chart following rules as specified by autoResize() and autoResizeToAspectRatio().
this does limit functionality a little, bit, but i think it fits better with common use cases and is less confusing to new users.
from d3kit.
I like the simplification, but specifying options via autoResize maybe less intuitive when I want to resize only once. How about grouping resize options together, which can be set via either resize(resizeOptions)
or autoResize(resizeOptions)
?
Then, call resize()
if you want to resize once, autoResize()
for auto-detect.
In resizeOptions
- auto:Boolean
- side: 'width', 'height' or 'both'
- aspectRatio: null or some value
With this we can also implement autoResize by calling resize and set auto to true.
On second thought, what about renaming both to fit()
and autoFit()
rather than resize()
?
from d3kit.
Resolved in v3
from d3kit.
Related Issues (19)
- Complete Documentation HOT 2
- add screen shot to README.md HOT 1
- Autoresize HOT 2
- Height sizing bug when CSS line-height not equal 0 HOT 3
- Auto-resizing only working in one direction HOT 2
- Added typescript type definition for d3Kit to DefinitelyTyped HOT 2
- Compatibility with d3 version 4 changes to dispatch HOT 4
- Cannot find module "d3kit" when importing in TypeScript HOT 2
- Potential problem with static AbstractChart.getCustomEventNames() HOT 1
- Add readme.md to treboresque demos
- Grouped (horizontal/vertical, stacked) bar charts not responsive
- Figure a common place for all gists HOT 2
- Create simple 'circle' chartlet
- Change charlet getCustomEvents() to getCustomEventNames()
- Add Travis CI support HOT 4
- Add CONTRIBUTING.md HOT 1
- Register to bower HOT 1
- wiki gone missing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from d3kit.