Giter Club home page Giter Club logo

Comments (4)

putnam120 avatar putnam120 commented on June 1, 2024

How are you calling the C++ code? The last function argument should be of type int, so I'm not sure how you aren't getting a run time error.

from breakoutdetection.

eamocanu avatar eamocanu commented on June 1, 2024

Hi
I changed the signature because it couldn't find IntegerVector to use an array, but that's not the point. In my call above I put Linear to show that it uses the linear function. Putting a 1 is not that clear (at least to me) Anyway, my point is not that the code is not working. The point is that the C++ code gives different results than the R code if you give it the parameters I show in my original post. I was wondering why that is the case. Maybe the code is broken so I'm just giving you a heads up.

from breakoutdetection.

putnam120 avatar putnam120 commented on June 1, 2024

Thanks for the clarification.

I modified my version of the package and was able to obtain the results that you mentioned.

However, there is nothing wrong with the package. If you look at the R code you will notice that before performing any analysis all of the values are scaled to be in the interval [0,1]. This is because R is able to handle arbitrarily larger numbers while C++ can't (well at least not with the standard libraries). If you perform the scaling and then apply the C++ method you obtain the same results.

Hope that helps.

from breakoutdetection.

eamocanu avatar eamocanu commented on June 1, 2024

Thanks for the explanation.

from breakoutdetection.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.