Giter Club home page Giter Club logo

Comments (9)

swiftyspiffy avatar swiftyspiffy commented on June 8, 2024 1

Yup, you’re probably right. Will look into this in like 10 hours.

from twitchlib.client.

JayDee23 avatar JayDee23 commented on June 8, 2024 1

I guess this would be the right time to leave a big THANK YOU for this great library.
Wrote my own small private bot with individual greetings and some other features belonging to my channel like a poem-command.

from twitchlib.client.

Mahsaap avatar Mahsaap commented on June 8, 2024

I dont see that code snippet. What file is that In
Nvm found it

from twitchlib.client.

JayDee23 avatar JayDee23 commented on June 8, 2024

ChatMessage.cs

https://github.com/TwitchLib/TwitchLib.Client/blob/master/TwitchLib.Client.Models/ChatMessage.cs
I don't know exactly if this is the latest version, I just googled twitchlib and the Property.

Nvm, read the last sentence too late :)

from twitchlib.client.

adepierre avatar adepierre commented on June 8, 2024

Just leaving this here for completeness: in case of a founder subscriber, the badge-info is not subscriber/month_count but founder/month_count, so both should be checked

from twitchlib.client.

swiftyspiffy avatar swiftyspiffy commented on June 8, 2024

Sorry for the delay on this, have been busy.

Good callout @adepierre , I believe that is the root problem. See #133

from twitchlib.client.

adepierre avatar adepierre commented on June 8, 2024

I think that #133 fixes #129 but only partially this issue (for founder subscribers). For regular subscribers, SubscribedMonthCount is still parsed from the badge value (which can only be 1, 3, 6, 12, 24 etc...) while it should parse the badge-info which contains the more accurate month count.

from twitchlib.client.

swiftyspiffy avatar swiftyspiffy commented on June 8, 2024

@adepierre You're right. Cutting new PR to fix the issue completely.

from twitchlib.client.

swiftyspiffy avatar swiftyspiffy commented on June 8, 2024

Should be resolved with this commit: 1182914

Feel free to reopen as needed.

from twitchlib.client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.