Comments (6)
Good Point, I would like to start an unstable branch and implement promises, then we could handle errors with the promise api. want to help? or have or suggestions?
from ngupload.
Personally I would take the lazy way out and just throw that line inside of a try/catch(err), with a return of the error. I don't know much about the JS promise API, but at the moment the support looks very low:
from ngupload.
OK, I added error handling. See this Gist:
https://gist.github.com/djvs/7c82f7395624d85c7e03
specifically lines 96 and 185-219 (one big try-catch). This adds support for an optional error-catcher attribute in the <form> tag. You may want to double check, I basically used your method for the ng-upload attribute.
from ngupload.
This would be huge for me. +1
from ngupload.
I will try to incorporate it by the weekend, I have been so busy, if you
need it before, wrapping it up in a pull-request would be welcomed.
Thanks
Tom
On Thu, Jul 31, 2014 at 1:49 PM, Ken Caron [email protected] wrote:
This would be huge for me.
—
Reply to this email directly or view it on GitHub
#112 (comment).
Tom Wilson
Jack Russell Software Company Division of CareKinesis
494 Wando Park Blvd
Mount Pleasant, SC 29464
Phone: 843-606-6484
Mobile: 843-469-5856
Email: [email protected]
Web: http://www.jackhq.com
Calendar:
http://www.google.com/calendar/embed?src=tom%40jackrussellsoftware.com&ctz=America/New_York
http://www.jackhq.com/calendar
This e-mail may contain information that is confidential, privileged or
otherwise protected from disclosure by the Health Insurance Portability and
Accountability Act (HIPAA) and other state and federal laws. This
information is intended only for the individual names above. Any review,
use disclosure or dissemination of this material is strictly prohibited.
If you receive this information in error, please notify CareKinesis
immediately at 888-974-2763 and delete the original at once.
from ngupload.
Added to master js, but not released...
Let me know if you see any issues:
from ngupload.
Related Issues (20)
- ngUpload not working on Firefox 27 Mac - returns HTML instead of JSON
- getting a warning in console
- How to prefix file name that is uploaded HOT 10
- Minified version causing form submitted multiple times HOT 7
- 404 not found HOT 2
- Setting custom headers HOT 8
- Auto start upload HOT 3
- custom headers using CORS in IE8 HOT 1
- Minified file not updated HOT 1
- $isLoading should be $isUploading in the readme HOT 1
- ng-upload executing multiple times
- ngUpload is not working HOT 3
- ng-upload.min.js is broken HOT 2
- How can we implement the progress bar for ngUpload? HOT 2
- Bower package is out-of-date HOT 3
- Hidden inputs do not work for objects
- Can we get upload percent in $scope? HOT 1
- BeforeSumbit executes after submit
- Is it possible to register the package on npm? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ngupload.