Comments (9)
Hrm. Looking at the setup.py for the 0.9.9.9 release it seems that you failed
to update the setup(version) prior to doing the builds. This seems to be a
chronic issue as it appears to be the case on svn/tags/impacket_0_9_8_0/ and
svn/tags/impacket_0_9_7_0/ also. You really need to make these things all
match up.
You cannot simply rename the resulting .tar.gz and expect everything to be good.
Original comment by [email protected]
on 3 Jan 2013 at 10:41
- Added labels: ****
- Removed labels: ****
from impacket.
Hey Brian:
Thanks for the report and sorry for the messed up package. We'll be fixing it
these days.
Stay tunned.
Original comment by [email protected]
on 6 Jan 2013 at 6:11
- Changed state: Accepted
- Added labels: ****
- Removed labels: ****
from impacket.
Original comment by [email protected]
on 10 Jan 2013 at 4:34
- Added labels: ****
- Removed labels: ****
from impacket.
Hi.
To be clear, you need to adjust the version in setup.py to reflect what you
want the resulting release to ship as, before you do the release process so
that things are all named/versioned correctly. I would suggest that that
version given should match the release branch/tag name.
Original comment by [email protected]
on 10 Jan 2013 at 4:53
- Added labels: ****
- Removed labels: ****
from impacket.
I've modified some of the properties of the setup.py file. This new version is
attached, does this modifications fix the issues you have to create the package.
Original comment by [email protected]
on 10 Jan 2013 at 7:17
- Added labels: ****
- Removed labels: ****
Attachments:
from impacket.
Well, that setup.py is fine if what you want as a result is
impacket-0.9.9.9.tar.gz. But you have already released 0.9.9.9 at:
http://corelabs.coresecurity.com/index.php?module=Wiki&action=attachment&type=to
ol&page=Impacket&file=impacket-0.9.9.9.tar.gz
Surely you don't actually want to re-release 0.9.9.9 right? If you don't, then
you need to decide what the version of the next release will be and set the
version property to that value.
Currently on trunk the version is 1.0.0.0-dev. That seems like a reasonable
version while trunk is in development given that the previous release was
0.9.9.9. But at the point where you are ready to do an official release, you
would want to set that version to "1.0.0.0" so that the tarball you get is
impacket-1.0.0.0.tar.gz (the zip file will be similar). It's that tarball (and
zip file) that you make available as your release to your users, _WITHOUT_
doing anything to them to change the version in their name. That's the
important part. Once "setup bdist" (or whatever variant you use) has created
and named the tarball and/or zip files, you cannot change the version (nor
should you really change the name) in the file name.
Original comment by [email protected]
on 22 Jan 2013 at 8:13
- Added labels: ****
- Removed labels: ****
from impacket.
Additionally at the point in the source tree where you did the "setup bdist" to
make your 1.0.0.0 release (with the setup.py version="1.0.0.0" you would create
a tag "impacket_1_0_0_0" so that you have perfect alignment of setup.py
version= value, the names on the released packages and the SCCS tag.
Original comment by [email protected]
on 22 Jan 2013 at 8:15
- Added labels: ****
- Removed labels: ****
from impacket.
Hey Brian..
Thanks for all your points.. we will not be changing 0.9.9.9 since, as you
said, it's already out there.
We will incorporate these changes whenever we release the next version.
thanks again,
beto
Original comment by [email protected]
on 25 Jan 2013 at 8:14
- Added labels: ****
- Removed labels: ****
from impacket.
We just published 0.9.10.. Hopefully those problems are solved.
Original comment by [email protected]
on 6 May 2013 at 5:47
- Changed state: Fixed
- Added labels: ****
- Removed labels: ****
from impacket.
Related Issues (20)
- smbrelayx.py prob HOT 9
- smbserver.py does not work with signing HOT 1
- SMBTransport instance has no attribute 'get_dce_rpc' HOT 5
- secretsdump.py not working against winXP HOT 1
- secretsdump not working against a Windows 2000 Server HOT 1
- Error on function set_bytes_from_string in ImpactPacket.py HOT 2
- Services.py pass the hash causes an error HOT 3
- Python 2.6 support for OrderedDict HOT 2
- esentutl.py crashes while dumping table from ntds.dit HOT 6
- retr_file permissions issue in smb.py HOT 12
- smbserver not working with OSX Mavericks
- On Windows 2012R2 reports Broken Pipe HOT 7
- SMB_FIND_FILE_BOTH_DIRECTORY_INFO FileName non-NUL terminated HOT 8
- Bad record decoding in ese.py HOT 3
- error: can only concatenate tuple (not "unicode") to tuple HOT 6
- secretsdump.py utf16 codec errors HOT 13
- SMBv1 stack doesn't talk unicode on the wire HOT 8
- New KRB5 module/lib isn't installed HOT 2
- Patch for /trunk/impacket/examples/serviceinstall.py HOT 1
- psexec.py script throwing exceptions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from impacket.