Comments (6)
Hey Bryan:
Thanks for the report.. I'll take a look it at..
Any specific MSF module you're using for testing this? ( I assume all of them
uses the same SMB client library, but just in case..)
cheers,
beto
Original comment by [email protected]
on 6 Sep 2012 at 1:28
- Added labels: ****
- Removed labels: ****
from impacket.
Original comment by [email protected]
on 6 Sep 2012 at 3:02
- Changed state: Accepted
- Added labels: ****
- Removed labels: ****
from impacket.
Okey.. I think it's fixed.. please verify...
I tested it with smb_login and smb_enumshares.
Actually metasploit, as you say,DOES send extended security in the neg packet
but not on the session_setup one.. Against a Windows 7 MSF does send it in both
packets. There must be something the in my negproto answer that confuses msf
(or something i'm returning not compliant with the protocol).
I haven't applied your fix tho.. main problem is you can't cast the data to
SMBSessionSetupAndX_Extended_Parameters if you're not sure whether or not the
client sent that. SMBSessionSetupAndX_Extended_Parameters and
SMBSessionSetupAndX_Parameters have different sizes. That would break clients
trying to connect with standard security, under some circumstances.
What I did is what [MS-SMB] recommends, which is still reading the Flags2 at
this stage to decide whether it's extended security or not.
One important note tho.. smbServer still does NOT support NTLMv2 authentication
using under standard security (this is what MSF does), it does under extended
security although right now we're granting access to everybody. So if you think
about checking usernames it won't work yet.
thanks again for the report Bryan..
cheers,
beto
Original comment by [email protected]
on 6 Sep 2012 at 3:38
- Changed state: Fixed
- Added labels: ****
- Removed labels: ****
from impacket.
Forgot to say...
fixed in http://code.google.com/p/impacket/source/detail?r=710
Original comment by [email protected]
on 6 Sep 2012 at 3:39
- Added labels: ****
- Removed labels: ****
from impacket.
Confirmed it has been fixed, thanks for the quick turnaround!
Original comment by [email protected]
on 6 Sep 2012 at 3:47
- Added labels: ****
- Removed labels: ****
from impacket.
Great :)
Check http://code.google.com/p/impacket/source/detail?r=711, I found out what
was wrong there too.. Now it's more compliant with [MS-SMB] and [MS-CIFS].
Cheers,
beto
Original comment by [email protected]
on 6 Sep 2012 at 4:03
- Added labels: ****
- Removed labels: ****
from impacket.
Related Issues (20)
- smbrelayx.py prob HOT 9
- smbserver.py does not work with signing HOT 1
- SMBTransport instance has no attribute 'get_dce_rpc' HOT 5
- secretsdump.py not working against winXP HOT 1
- secretsdump not working against a Windows 2000 Server HOT 1
- Error on function set_bytes_from_string in ImpactPacket.py HOT 2
- Services.py pass the hash causes an error HOT 3
- Python 2.6 support for OrderedDict HOT 2
- esentutl.py crashes while dumping table from ntds.dit HOT 6
- retr_file permissions issue in smb.py HOT 12
- smbserver not working with OSX Mavericks
- On Windows 2012R2 reports Broken Pipe HOT 7
- SMB_FIND_FILE_BOTH_DIRECTORY_INFO FileName non-NUL terminated HOT 8
- Bad record decoding in ese.py HOT 3
- error: can only concatenate tuple (not "unicode") to tuple HOT 6
- secretsdump.py utf16 codec errors HOT 13
- SMBv1 stack doesn't talk unicode on the wire HOT 8
- New KRB5 module/lib isn't installed HOT 2
- Patch for /trunk/impacket/examples/serviceinstall.py HOT 1
- psexec.py script throwing exceptions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from impacket.